woocommerce/plugins/woocommerce-admin/patches/@automattic+explat-client-r...

30 lines
1.2 KiB
Diff
Raw Normal View History

Enable Typescript checking on ./client folder (https://github.com/woocommerce/woocommerce-admin/pull/8372) * Copied .tsconfig into ./client to enable ts checking - Made sub-repos composite typescript packages where necessary * Prevent tsc from transpiling ./client - we use webpack for transpiling so no need for this * Added tsc resolution path for @automattic/explat-client - Seems like there's a type export issue (?) with @automattic/explat-client and @automattic/explat-client-react-helpers - adding the node_modules/@automattic/explat-client path in tsconfig seems to help TS resolve this using the source .ts files - found answer here: https://github.com/microsoft/TypeScript/issues/42873 - should figure out what's actually wrong with the type exports and fix that there instead * Removed mandatory checking from webpack - removed this for now as it will block all development until all type inconsistencies are fixed - for now, run the optional ts:check task either in console or vscode for highlighting type errors * Added vscode tasks for typescript checking * Patch @automattic/explat-client-react-helpers - this changes the installed code in node_modules (post-installation) for @automattic/explat-client-react-helpers so that it exports the necessary type interfaces required by us - attempted unsuccessfully to override type exports using declare module - not too sure how to fix this internally by other means - have to investigate what fixes to propose to @automattic/explat-client-react-helpers team * changed tests in ./client to use ts-jest instead of babel-jest - rewrote jest config to use ts-jest instead of babel-jest - set ts errors to warnings instead so that tests don't fail on type errors - created new tsconfig for ./packages/js-tests so that build and ts-check are separate, as js-tests need to be built for commonjs
2022-03-01 04:19:07 +00:00
diff --git a/node_modules/@automattic/explat-client-react-helpers/dist/types/index.d.ts b/node_modules/@automattic/explat-client-react-helpers/dist/types/index.d.ts
index 594f134..22f31d1 100644
--- a/node_modules/@automattic/explat-client-react-helpers/dist/types/index.d.ts
+++ b/node_modules/@automattic/explat-client-react-helpers/dist/types/index.d.ts
@@ -1,6 +1,6 @@
import * as React from 'react';
import type { ExPlatClient, ExperimentAssignment } from '@automattic/explat-client';
-interface ExperimentOptions {
+export interface ExperimentOptions {
/**
* Determines whether a participant is currenlty eligible for an assignment.
* - Only loads the experimentAssignment if isEligible is true.
@@ -8,7 +8,7 @@ interface ExperimentOptions {
*/
isEligible?: boolean;
}
-interface ExPlatClientReactHelpers {
+export interface ExPlatClientReactHelpers {
/**
* An ExPlat useExperiment hook.
*
@@ -38,5 +38,5 @@ interface ExPlatClientReactHelpers {
}) => JSX.Element;
}
export default function createExPlatClientReactHelpers(exPlatClient: ExPlatClient): ExPlatClientReactHelpers;
-export {};
+// export {};
//# sourceMappingURL=index.d.ts.map
\ No newline at end of file