From 0036b4d293a9ad4e19b47f553c925ff1cd996abf Mon Sep 17 00:00:00 2001
From: RJ <27843274+rjchow@users.noreply.github.com>
Date: Tue, 17 Sep 2024 11:33:41 +1000
Subject: [PATCH] add: tax task completion filter (#51362)

* add: tax task completion filter

* fix: add phpcs ignore for missing hook comment

* lint
---
 .../woocommerce/changelog/add-tax-task-completion-filter | 4 ++++
 .../src/Admin/Features/OnboardingTasks/Tasks/Tax.php     | 9 +++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 plugins/woocommerce/changelog/add-tax-task-completion-filter

diff --git a/plugins/woocommerce/changelog/add-tax-task-completion-filter b/plugins/woocommerce/changelog/add-tax-task-completion-filter
new file mode 100644
index 00000000000..89ab40a7240
--- /dev/null
+++ b/plugins/woocommerce/changelog/add-tax-task-completion-filter
@@ -0,0 +1,4 @@
+Significance: patch
+Type: add
+
+Adds a filter for third party tax plugins to indicate that they have completed the tax task
diff --git a/plugins/woocommerce/src/Admin/Features/OnboardingTasks/Tasks/Tax.php b/plugins/woocommerce/src/Admin/Features/OnboardingTasks/Tasks/Tax.php
index ba33d9b2362..b0a65b969e6 100644
--- a/plugins/woocommerce/src/Admin/Features/OnboardingTasks/Tasks/Tax.php
+++ b/plugins/woocommerce/src/Admin/Features/OnboardingTasks/Tasks/Tax.php
@@ -15,6 +15,7 @@ class Tax extends Task {
 
 	/**
 	 * Used to cache is_complete() method result.
+	 *
 	 * @var null
 	 */
 	private $is_complete_result = null;
@@ -109,12 +110,16 @@ class Tax extends Task {
 	 */
 	public function is_complete() {
 		if ( $this->is_complete_result === null ) {
-			$wc_connect_taxes_enabled = get_option( 'wc_connect_taxes_enabled' );
+			$wc_connect_taxes_enabled    = get_option( 'wc_connect_taxes_enabled' );
 			$is_wc_connect_taxes_enabled = ( $wc_connect_taxes_enabled === 'yes' ) || ( $wc_connect_taxes_enabled === true ); // seems that in some places boolean is used, and other places 'yes' | 'no' is used
 
+			// phpcs:ignore WooCommerce.Commenting.CommentHooks.MissingHookComment -- We will replace this with a formal system by WC 9.6 so lets not advertise it yet.
+			$third_party_complete = apply_filters( 'woocommerce_admin_third_party_tax_setup_complete', false );
+
 			$this->is_complete_result = $is_wc_connect_taxes_enabled ||
 				count( TaxDataStore::get_taxes( array() ) ) > 0 ||
-				get_option( 'woocommerce_no_sales_tax' ) !== false;
+				get_option( 'woocommerce_no_sales_tax' ) !== false ||
+				$third_party_complete;
 		}
 
 		return $this->is_complete_result;