Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve the TODO comments in the admin notice add and remove methods

This commit is contained in:
Nestor Soriano 2023-10-04 11:26:29 +02:00
parent 3a07007b40
commit 0533ad40af
No known key found for this signature in database
GPG Key ID: 08110F3518C12CAD
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/woocommerce/includes/admin/class-wc-admin-notices.php
View File

@ -122,10 +122,12 @@ class WC_Admin_Notices {
self::maybe_add_legacy_api_removal_notice(); self::maybe_add_legacy_api_removal_notice();
} }
// phpcs:disable Generic.Commenting.Todo.TaskFound
/** /**
* Add an admin notice about the removal of the Legacy REST API if the said API is enabled. * Add an admin notice about the removal of the Legacy REST API if the said API is enabled.
* *
* TODO: Remove this method in WooCommerce 9.0. * TODO: Change this method in WooCommerce 9.0 so that it checks if the Legacy REST API extension is installed, and if not, it points to the extension URL in the WordPress plugins directory.
*/ */
private static function maybe_add_legacy_api_removal_notice() { private static function maybe_add_legacy_api_removal_notice() {
if ( 'yes' !== get_option( 'woocommerce_api_enabled' ) ) { if ( 'yes' !== get_option( 'woocommerce_api_enabled' ) ) {
@ -153,7 +155,7 @@ class WC_Admin_Notices {
/** /**
* Remove the admin notice about the removal of the Legacy REST API if the said API is disabled. * Remove the admin notice about the removal of the Legacy REST API if the said API is disabled.
* *
* TODO: Remove this method in WooCommerce 9.0. * TODO: Change this method in WooCommerce 9.0 so that the notice gets removed if the Legacy REST API extension is installed and active.
*/ */
private static function maybe_remove_legacy_api_removal_notice() { private static function maybe_remove_legacy_api_removal_notice() {
if ( 'yes' !== get_option( 'woocommerce_api_enabled' ) && self::has_notice( 'legacy_api_removed_in_woo_90' ) ) { if ( 'yes' !== get_option( 'woocommerce_api_enabled' ) && self::has_notice( 'legacy_api_removed_in_woo_90' ) ) {
@ -161,6 +163,8 @@ class WC_Admin_Notices {
} }
} }
// phpcs:enable Generic.Commenting.Todo.TaskFound
/** /**
* Show a notice. * Show a notice.
* *