From 68c8bfedd92b0a63054ac85b3a746fd6f3724c33 Mon Sep 17 00:00:00 2001 From: Paul Sealock Date: Mon, 24 Jun 2019 11:58:29 +1200 Subject: [PATCH] Table extension: fix page error and jsDoc --- .../client/analytics/components/report-table/index.js | 2 +- .../docs/examples/extensions/table-column/js/index.js | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/plugins/woocommerce-admin/client/analytics/components/report-table/index.js b/plugins/woocommerce-admin/client/analytics/components/report-table/index.js index d898e52ea1e..14f43789a51 100644 --- a/plugins/woocommerce-admin/client/analytics/components/report-table/index.js +++ b/plugins/woocommerce-admin/client/analytics/components/report-table/index.js @@ -118,7 +118,7 @@ class ReportTable extends Component { * @param {array} reportTableData.rows - table rows data. * @param {object} reportTableData.totals - total aggregates for request. * @param {array} reportTableData.summary - summary numbers data. - * @param {array} reportTableData.items - response from api requerst. + * @param {object} reportTableData.items - response from api requerst. */ const { headers, ids, rows, summary } = applyFilters( TABLE_FILTER, { endpoint, diff --git a/plugins/woocommerce-admin/docs/examples/extensions/table-column/js/index.js b/plugins/woocommerce-admin/docs/examples/extensions/table-column/js/index.js index d5b2017dacb..0893ccad32b 100644 --- a/plugins/woocommerce-admin/docs/examples/extensions/table-column/js/index.js +++ b/plugins/woocommerce-admin/docs/examples/extensions/table-column/js/index.js @@ -7,7 +7,12 @@ import { addFilter } from '@wordpress/hooks'; import { Rating } from '@woocommerce/components'; addFilter( 'woocommerce_admin_report_table', 'plugin-domain', reportTableData => { - if ( 'products' !== reportTableData.endpoint || ! reportTableData.items.data.length ) { + if ( + 'products' !== reportTableData.endpoint || + ! reportTableData.items || + ! reportTableData.items.data || + ! reportTableData.items.data.length + ) { return reportTableData; } @@ -33,7 +38,9 @@ addFilter( 'woocommerce_admin_report_table', 'plugin-domain', reportTableData => }, // average_rating can be found on extended_info on productData. { - display: , + display: ( + + ), value: product.extended_info.average_rating, }, ];