Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request woocommerce/woocommerce-admin#910 from woocommerce/fix/chart-empty-data 

Bug: noticed a new NaN error caused by attempt to draw chart with empty data
This commit is contained in:
Robert Elliott 2018-11-27 11:39:40 +02:00 committed by GitHub
parent eddf8bc609 2ac101f1c2
commit 0a134d2d53
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce-admin/client/components/d3chart/index.js vendored
View File

@ -3,7 +3,7 @@
/** /**
* External dependencies * External dependencies
*/ */
import { isEqual } from 'lodash'; import { isEmpty, isEqual } from 'lodash';
import { Component, createRef } from '@wordpress/element'; import { Component, createRef } from '@wordpress/element';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import classNames from 'classnames'; import classNames from 'classnames';
@ -162,7 +162,7 @@ class D3Chart extends Component {
} }
render() { render() {
if ( ! this.props.data ) { if ( isEmpty( this.props.data ) ) {
return null; // TODO: improve messaging return null; // TODO: improve messaging
} }
return ( return (