Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Exclude inactive plugins from the incompatible plugins view (#35333) 

* Changes in the plugin-feature compatibility warnings:

- Show only active plugins in the "Incompatible with..." plugins view
- Show an empty page when the view is loaded and no Incompatible
  plugins are active (instead of listing all the existing plugins)

* Add changelog file
This commit is contained in:
Néstor Soriano 2022-10-31 12:41:06 +01:00 committed by GitHub
parent 6c551b0cd6
commit 11e22063ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/remove_compatibility_warnings_for_inactive_plugins Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: update
Don't show feature compatibility warnings for inactive plugins

18
plugins/woocommerce/src/Internal/Features/FeaturesController.php
View File

@ -725,7 +725,7 @@ class FeaturesController {
// phpcs:enable WordPress.Security.NonceVerification
foreach ( array_keys( $list ) as $plugin_name ) {
if ( ! $this->plugin_util->is_woocommerce_aware_plugin( $plugin_name ) ) {
if ( ! $this->plugin_util->is_woocommerce_aware_plugin( $plugin_name ) || ! $this->proxy->call_function( 'is_plugin_active', $plugin_name ) ) {
continue;
}
@ -740,10 +740,6 @@ class FeaturesController {
}
}
if ( 0 === count( $incompatibles ) ) {
return $list;
}
return array_intersect_key( $list, array_flip( $incompatibles ) );
}
@ -832,10 +828,10 @@ class FeaturesController {
$message =
'all' === $feature_id
? __( 'You are viewing plugins that are incompatible with currently enabled WooCommerce features.', 'woocommerce' )
? __( 'You are viewing active plugins that are incompatible with currently enabled WooCommerce features.', 'woocommerce' )
: sprintf(
/* translators: %s is a feature name. */
__( "You are viewing the plugins that are incompatible with the '%s' feature.", 'woocommerce' ),
__( "You are viewing the active plugins that are incompatible with the '%s' feature.", 'woocommerce' ),
$this->features[ $feature_id ]['name']
);
@ -867,11 +863,15 @@ class FeaturesController {
private function handle_plugin_list_rows( $plugin_file, $plugin_data ) {
global $wp_list_table;
if ( 'incompatible_with_feature' !== ArrayUtil::get_value_or_default( $_GET, 'plugin_status' ) ) { // phpcs:ignore WordPress.Security.NonceVerification
return;
}
if ( is_null( $wp_list_table ) || ! $this->plugin_util->is_woocommerce_aware_plugin( $plugin_data ) ) {
return;
}
if ( 'incompatible_with_feature' !== ArrayUtil::get_value_or_default( $_GET, 'plugin_status' ) ) { // phpcs:ignore WordPress.Security.NonceVerification
if ( ! $this->proxy->call_function( 'is_plugin_active', $plugin_file ) ) {
return;
}
@ -889,7 +889,7 @@ class FeaturesController {
$incompatible_features_count = count( $incompatible_features );
if ( $incompatible_features_count > 0 ) {
$columns_count = $wp_list_table->get_column_count();
$is_active = $this->proxy->call_function( 'is_plugin_active', $plugin_file );
$is_active = true; // For now we are showing active plugins in the "Incompatible with..." view.
$is_active_class = $is_active ? 'active' : 'inactive';
$is_active_td_style = $is_active ? " style='border-left: 4px solid #72aee6;'" : '';