Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix manual entry within Quantity Inputs (https://github.com/woocommerce/woocommerce-blocks/pull/5197) 

* Use Number.isNaN to cast strings

* Avoid changing type function
This commit is contained in:
Mike Jolley 2021-11-22 12:09:00 +00:00 committed by GitHub
parent 91008a6492
commit 128ef97010
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce-blocks/assets/js/base/components/quantity-selector/index.tsx
View File

@ -6,7 +6,6 @@ import { speak } from '@wordpress/a11y';
import classNames from 'classnames';
import { useCallback } from '@wordpress/element';
import { DOWN, UP } from '@wordpress/keycodes';
import { isNumber } from '@woocommerce/types';
/**
* Internal dependencies
@ -84,7 +83,8 @@ const QuantitySelector = ( {
onKeyDown={ quantityInputOnKeyDown }
onChange={ ( event ) => {
let value =
! isNumber( event.target.value ) || ! event.target.value
Number.isNaN( event.target.value ) ||
! event.target.value
? 0
: parseInt( event.target.value, 10 );
if ( hasMaximum ) {