Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed test for 4.0.

This commit is contained in:
Peter Fabian 2020-01-31 21:05:50 +01:00
parent e83934edff
commit 132ced6039
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
includes/admin/plugin-updates/class-wc-plugin-updates.php
View File

@ -173,6 +173,10 @@ class WC_Plugin_Updates {
/** /**
* Get active plugins that have a tested version lower than the input version. * Get active plugins that have a tested version lower than the input version.
* *
* In case of testing major version compatibility and if current WC version is >= major version part
* of the $new_version, no plugins are returned, even if they don't explicitly declare compatibility
* with the $new_version.
*
* @param string $new_version WooCommerce version to test against. * @param string $new_version WooCommerce version to test against.
* @param string $release 'major' or 'minor'. * @param string $release 'major' or 'minor'.
* @return array of plugin info arrays * @return array of plugin info arrays

18
tests/unit-tests/util/plugin-updates.php
View File

@ -1,4 +1,9 @@
<?php <?php
/**
* File for the WC_Tests_Plugin_Updates class.
*
* @package WooCommerce\Tests\Util
*/
/** /**
* Class WC_Plugin_Updates. * Class WC_Plugin_Updates.
@ -127,15 +132,22 @@ class WC_Tests_Plugin_Updates extends WC_Unit_Test_Case {
); );
$plugin_keys = array_keys( $this->plugins ); $plugin_keys = array_keys( $this->plugins );
$new_version = '4.0.0'; // current: X.Y.Z, new: (X+1).0.
// as current < new, all plugins are untested.
$current_version_parts = explode( '.', WC_VERSION );
$new_version = ( $current_version_parts[0] + 1 ) . '.0.0';
$untested = $this->updates->get_untested_plugins( $new_version, $release ); $untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) ); $this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
$new_version = '4.3.0'; // current: X.Y.Z, new: (X+1).3.0.
// as current < new, all plugins are untested.
$new_version = ( $current_version_parts[0] + 1 ) . '.3.0';
$untested = $this->updates->get_untested_plugins( $new_version, $release ); $untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) ); $this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
$new_version = '4.0.2'; // current: X.Y.Z, new: (X+1).0.2.
// as current < new, all plugins are untested.
$new_version = ( $current_version_parts[0] + 1 ) . '.0.2';
$untested = $this->updates->get_untested_plugins( $new_version, $release ); $untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) ); $this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
} }