Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix failing e2e test merchant/settings-tax (#48792) 

* Remove unnecessary step in the settings tax test

* Add changelog

* Remove unnecessary waituntil
This commit is contained in:
Veljko V 2024-06-25 13:46:52 +02:00 committed by GitHub
parent 7a8d5e0b6d
commit 134f431187
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/e2e-fix-settings-tax-test Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: dev
E2E tests: fix failing settings-tax e2e test

23
plugins/woocommerce/tests/e2e-pw/tests/merchant/settings-tax.spec.js
View File

@ -56,9 +56,7 @@ test.describe.serial( 'WooCommerce Tax Settings', () => {
} );
test( 'can set tax options', async ( { page } ) => {
await page.goto( 'wp-admin/admin.php?page=wc-settings&tab=tax', {
waitUntil: 'networkidle',
} );
await page.goto( 'wp-admin/admin.php?page=wc-settings&tab=tax', {} );
// Make sure we're on the tax tab
await expect( page.locator( 'a.nav-tab-active' ) ).toContainText(
@ -117,26 +115,12 @@ test.describe.serial( 'WooCommerce Tax Settings', () => {
} );
test( 'can add tax classes', async ( { page } ) => {
await page.goto( 'wp-admin/admin.php?page=wc-settings&tab=tax', {
waitUntil: 'networkidle',
} );
await page.goto( 'wp-admin/admin.php?page=wc-settings&tab=tax', {} );
await expect( page.locator( 'a.nav-tab-active' ) ).toContainText(
'Tax'
);
// Clear out existing tax classes
await page.locator( '#woocommerce_tax_classes' ).fill( '' );
await page.locator( 'text=Save changes' ).click();
// Verify that the settings have been saved
await expect( page.locator( 'div.updated.inline' ) ).toContainText(
'Your settings have been saved.'
);
await expect( page.locator( '#woocommerce_tax_classes' ) ).toHaveValue(
''
);
// Add a "fancy" tax class
await page.locator( '#woocommerce_tax_classes' ).fill( 'Fancy' );
await page.locator( 'text=Save changes' ).click();
@ -152,8 +136,7 @@ test.describe.serial( 'WooCommerce Tax Settings', () => {
test( 'can set rate settings', async ( { page } ) => {
await page.goto(
'wp-admin/admin.php?page=wc-settings&tab=tax&section=fancy',
{ waitUntil: 'networkidle' }
'wp-admin/admin.php?page=wc-settings&tab=tax&section=fancy'
);
// Make sure the tax tab is active, with the "fancy" subsection