Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13284 from woocommerce/fix-13275 

Maintain support for non-prefixed item meta array access
This commit is contained in:
Mike Jolley 2017-02-23 13:47:40 +00:00 committed by GitHub
parent 1552ed8d6d 7846def9b8
commit 1463d2a9ba
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
includes/class-wc-order-item.php
View File

@ -252,7 +252,7 @@ class WC_Order_Item extends WC_Data implements ArrayAccess {
} }
} }
$this->update_meta_data( '_' . $offset, $value ); $this->update_meta_data( $offset, $value );
} }
/** /**
@ -275,7 +275,7 @@ class WC_Order_Item extends WC_Data implements ArrayAccess {
unset( $this->changes[ $offset ] ); unset( $this->changes[ $offset ] );
} }
$this->delete_meta_data( '_' . $offset ); $this->delete_meta_data( $offset );
} }
/** /**
@ -288,7 +288,7 @@ class WC_Order_Item extends WC_Data implements ArrayAccess {
if ( 'item_meta_array' === $offset || 'item_meta' === $offset || array_key_exists( $offset, $this->data ) ) { if ( 'item_meta_array' === $offset || 'item_meta' === $offset || array_key_exists( $offset, $this->data ) ) {
return true; return true;
} }
return array_key_exists( '_' . $offset, wp_list_pluck( $this->meta_data, 'value', 'key' ) ); return array_key_exists( $offset, wp_list_pluck( $this->meta_data, 'value', 'key' ) ) || array_key_exists( '_' . $offset, wp_list_pluck( $this->meta_data, 'value', 'key' ) );
} }
/** /**
@ -298,6 +298,7 @@ class WC_Order_Item extends WC_Data implements ArrayAccess {
*/ */
public function offsetGet( $offset ) { public function offsetGet( $offset ) {
$this->maybe_read_meta_data(); $this->maybe_read_meta_data();
if ( 'item_meta_array' === $offset ) { if ( 'item_meta_array' === $offset ) {
$return = array(); $return = array();
@ -322,6 +323,8 @@ class WC_Order_Item extends WC_Data implements ArrayAccess {
} elseif ( array_key_exists( '_' . $offset, $meta_values ) ) { } elseif ( array_key_exists( '_' . $offset, $meta_values ) ) {
// Item meta was expanded in previous versions, with prefixes removed. This maintains support. // Item meta was expanded in previous versions, with prefixes removed. This maintains support.
return $meta_values[ '_' . $offset ]; return $meta_values[ '_' . $offset ];
} elseif ( array_key_exists( $offset, $meta_values ) ) {
return $meta_values[ $offset ];
} }
return null; return null;