From 164a55b0d299ecd3d6ab3ca5b372e71d0b3a6c7b Mon Sep 17 00:00:00 2001 From: Jeff Stieler Date: Fri, 22 Mar 2019 14:29:17 -0600 Subject: [PATCH] Allow strings in downloads report order number filter. --- .../components/src/search/autocompleters/orders.js | 10 +--------- plugins/woocommerce-admin/tests/api/orders.php | 2 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/plugins/woocommerce-admin/packages/components/src/search/autocompleters/orders.js b/plugins/woocommerce-admin/packages/components/src/search/autocompleters/orders.js index c4c1b3df63f..042a7cda115 100644 --- a/plugins/woocommerce-admin/packages/components/src/search/autocompleters/orders.js +++ b/plugins/woocommerce-admin/packages/components/src/search/autocompleters/orders.js @@ -3,7 +3,6 @@ * External dependencies */ import apiFetch from '@wordpress/api-fetch'; -import { isNaN } from 'lodash'; /** * WooCommerce dependencies @@ -24,18 +23,11 @@ import { computeSuggestionMatch } from './utils'; export default { name: 'orders', className: 'woocommerce-search__order-result', - inputType: 'number', options( search ) { let payload = ''; if ( search ) { - const number = parseInt( search ); - - if ( isNaN( number ) ) { - return; - } - const query = { - number, + number: search, per_page: 10, }; payload = stringifyQuery( query ); diff --git a/plugins/woocommerce-admin/tests/api/orders.php b/plugins/woocommerce-admin/tests/api/orders.php index 25f763ea2b6..2e3df65f7eb 100644 --- a/plugins/woocommerce-admin/tests/api/orders.php +++ b/plugins/woocommerce-admin/tests/api/orders.php @@ -46,7 +46,7 @@ class WC_Tests_API_Orders extends WC_REST_Unit_Test_Case { $request = new WP_REST_Request( 'GET', $this->endpoint ); $request->set_query_params( array( - 'number' => $order->get_id(), + 'number' => (string) $order->get_id(), ) );