Code clean

src/experiments/data/reducer.js

@@ -10,16 +10,15 @@ const DEFAULT_STATE = {
 const reducer = (state = DEFAULT_STATE, action) => {
 	switch (action.type) {
 		case TYPES.TOGGLE_EXPERIMENT:
-			let experiments = [...state.experiments];
-			experiments = experiments.map((experiment) => {
-				if (experiment.name === action.experimentName) {
-					experiment.variation = action.newVariation;
-				}
-				return experiment;
-			});
 			return {
 				...state,
-				experiments,
+				experiments: state.experiments.map((experiment) => ({
+					...experiment,
+					variation:
+						experiment.name === action.experimentName
+							? action.newVariation
+							: experiment.variation,
+				})),
 			};
 		case TYPES.SET_EXPERIMENTS:
 			return {

src/experiments/data/resolvers.js

@@ -7,25 +7,17 @@ import { EXPERIMENT_NAME_PREFIX } from './constants';
 export function* getExperiments() {
 	const storageItems = Object.entries({ ...window.localStorage }).filter(
 		(item) => {
-			if (item[0].indexOf(EXPERIMENT_NAME_PREFIX) === 0) {
+			return item[0].indexOf(EXPERIMENT_NAME_PREFIX) === 0;
-				return true;
-			}
-			return false;
 		}
 	);
 
-	const experiments = [];
+	const experiments = storageItems.map((storageItem) => {
-	storageItems.forEach((storageItem) => {
 		const [key, value] = storageItem;
 		const objectValue = JSON.parse(value);
-
+		return {
-		const experiment = {
 			name: key.replace(EXPERIMENT_NAME_PREFIX, ''),
-			variation: objectValue.variationName
+			variation: objectValue.variationName || 'control',
-				? objectValue.variationName
-				: 'control',
 		};
-		experiments.push(experiment);
 	});
 
 	yield setExperiments(experiments);