Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CYS: show logo when the header is updated (#49681) 

* CYS: show logo when the header is updated

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Luigi Teschio 2024-07-19 10:03:56 +02:00 committed by GitHub
parent d0bd9f193a
commit 1a7619a4fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 47 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/woocommerce-admin/client/customize-store/assembler-hub/hooks/auto-block-preview-event-listener.ts
View File

@ -338,16 +338,14 @@ export const useAddAutoBlockPreviewEventListenersAndObservers = (
setStyle( documentElement );
if ( logoBlockIds.length === 0 ) {
const logoObserver = findAndSetLogoBlock(
{ autoScale, documentElement },
{
setLogoBlockIds,
}
);
const logoObserver = findAndSetLogoBlock(
{ autoScale, documentElement },
{
setLogoBlockIds,
}
);
observers.push( logoObserver );
}
observers.push( logoObserver );
if (
isFullComposabilityFeatureAndAPIAvailable() &&

4
plugins/woocommerce/changelog/49681-49668-infinite-loading-for-the-logo-in-cys-when-switching-header-and-attempting-to-change-added-logo Normal file
View File

@ -0,0 +1,4 @@
Significance: minor
Type: fix
CYS: show logo when the header is updated.

4
plugins/woocommerce/tests/e2e-pw/tests/customize-store/assembler/logo-picker/logo-picker.page.js
View File

@ -49,6 +49,10 @@ export class LogoPickerPage {
.click();
}
getPlaceholderPreview( assemblerLocator ) {
return assemblerLocator.locator( '.components-placeholder__preview' );
}
async resetLogo( baseURL ) {
const apiContext = await this.request.newContext( {
baseURL,

32
plugins/woocommerce/tests/e2e-pw/tests/customize-store/assembler/logo-picker/logo-picker.spec.js
View File

@ -187,6 +187,38 @@ test.describe( 'Assembler -> Logo Picker', { tag: '@gutenberg' }, () => {
await expect( assembler.getByText( 'Media Library' ) ).toBeVisible();
} );
// This test checks this regression: https://github.com/woocommerce/woocommerce/issues/49668
test( 'Logo should be visible after header update', async ( {
assemblerPageObject,
logoPickerPageObject,
} ) => {
const assembler = await assemblerPageObject.getAssembler();
const emptyLogoPicker =
logoPickerPageObject.getEmptyLogoPickerLocator( assembler );
await emptyLogoPicker.click();
await logoPickerPageObject.pickImage( assembler );
await assembler.getByLabel( 'Back' ).click();
await assembler.getByText( 'Choose your header' ).click();
const header = assembler
.locator( '.block-editor-block-patterns-list__list-item' )
.nth( 1 )
.frameLocator( 'iframe' )
.locator( '.wc-blocks-header-pattern' );
await header.click();
await assembler.getByLabel( 'Back' ).click();
await assembler.getByText( 'Add your logo' ).click();
const emptyLogoLocator =
logoPickerPageObject.getPlaceholderPreview( assembler );
await expect( emptyLogoLocator ).toBeHidden();
} );
test( 'Enabling the "use as site icon" option should set the image as the site icon', async ( {
page,
assemblerPageObject,