From 1a98d24b38de9dfd5427eea6f36c22584699ba04 Mon Sep 17 00:00:00 2001 From: Mike Jolley Date: Thu, 13 Jun 2019 16:54:53 +0100 Subject: [PATCH] More abstract methods --- .../Version4/AbstractObjectsController.php | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/Controllers/Version4/AbstractObjectsController.php b/src/Controllers/Version4/AbstractObjectsController.php index c933c92a56a..642b2235dc7 100644 --- a/src/Controllers/Version4/AbstractObjectsController.php +++ b/src/Controllers/Version4/AbstractObjectsController.php @@ -143,12 +143,9 @@ abstract class AbstractObjectsController extends AbstractController { * @since 3.0.0 * @param \WC_Data $object Object data. * @param \WP_REST_Request $request Request object. - * @return \WP_Error|\WP_REST_Response Response object on success, or \WP_Error object on failure. + * @return \WP_REST_Response Response object on success, or \WP_Error object on failure. */ - protected function prepare_object_for_response( $object, $request ) { - // translators: %s: Class method name. - return new \WP_Error( 'invalid-method', sprintf( __( "Method '%s' not implemented. Must be overridden in subclass.", 'woocommerce' ), __METHOD__ ), array( 'status' => 405 ) ); - } + abstract protected function prepare_object_for_response( $object, $request ); /** * Prepares one object for create or update operation. @@ -156,12 +153,9 @@ abstract class AbstractObjectsController extends AbstractController { * @since 3.0.0 * @param \WP_REST_Request $request Request object. * @param bool $creating If is creating a new object. - * @return \WP_Error|\WC_Data The prepared item, or \WP_Error object on failure. + * @return \WC_Data The prepared item, or \WP_Error object on failure. */ - protected function prepare_object_for_database( $request, $creating = false ) { - // translators: %s: Class method name. - return new \WP_Error( 'invalid-method', sprintf( __( "Method '%s' not implemented. Must be overridden in subclass.", 'woocommerce' ), __METHOD__ ), array( 'status' => 405 ) ); - } + abstract protected function prepare_object_for_database( $request, $creating = false ); /** * Get a single item.