diff --git a/plugins/woocommerce-beta-tester/.eslintrc b/plugins/woocommerce-beta-tester/.eslintrc index c3baa9032fb..a6708d0812a 100644 --- a/plugins/woocommerce-beta-tester/.eslintrc +++ b/plugins/woocommerce-beta-tester/.eslintrc @@ -25,7 +25,9 @@ "jsdoc/check-tag-names": [ "error", { "definedTags": [ "jest-environment" ] } - ] + ], + "react/react-in-jsx-scope": "off", + "no-alert": "off" }, "parserOptions": { "ecmaVersion": 6 diff --git a/plugins/woocommerce-beta-tester/assets/js/version-information.js b/plugins/woocommerce-beta-tester/assets/js/version-information.js index 317d43bb69a..ef69c4d2aaf 100644 --- a/plugins/woocommerce-beta-tester/assets/js/version-information.js +++ b/plugins/woocommerce-beta-tester/assets/js/version-information.js @@ -4,6 +4,7 @@ * @package */ +// eslint-disable-next-line no-undef jQuery( function ( $ ) { /** * Version information @@ -22,7 +23,7 @@ jQuery( function ( $ ) { /** * Handler for showing/hiding version information modal * - * @param event + * @param {Event} event */ showModal( event ) { event.preventDefault(); @@ -37,7 +38,9 @@ jQuery( function ( $ ) { $( this ).WCBackboneModal( { template: 'wc-beta-tester-version-info', variable: { + // eslint-disable-next-line no-undef version: wc_beta_tester_version_info_params.version, + // eslint-disable-next-line no-undef description: wc_beta_tester_version_info_params.description, }, } ); diff --git a/plugins/woocommerce-beta-tester/assets/js/version-picker.js b/plugins/woocommerce-beta-tester/assets/js/version-picker.js index 89288038e62..2c15e993cbb 100644 --- a/plugins/woocommerce-beta-tester/assets/js/version-picker.js +++ b/plugins/woocommerce-beta-tester/assets/js/version-picker.js @@ -4,6 +4,7 @@ * @package */ +// eslint-disable-next-line no-undef jQuery( function ( $ ) { /** * Version picker @@ -13,7 +14,7 @@ jQuery( function ( $ ) { * Initialize Version Information click */ init() { - instance = this; + const instance = this; instance.new_version = undefined; $( '#wcbt-modal-version-switch-confirm' ).on( @@ -32,12 +33,15 @@ jQuery( function ( $ ) { /** * Handler for showing/hiding version switch modal * - * @param event + * @param {Event} event */ showConfirmVersionSwitchModal( event ) { event.preventDefault(); + const instance = this; + if ( ! instance.new_version ) { + // eslint-disable-next-line no-undef alert( wc_beta_tester_version_picker_params.i18n_pick_version ); } else { $( this ).WCBackboneModal( { @@ -57,7 +61,7 @@ jQuery( function ( $ ) { /** * Submit form to switch version of WooCommerce. * - * @param event + * @param {Event} event */ submitSwitchVersionForm( event ) { event.preventDefault(); diff --git a/plugins/woocommerce-beta-tester/package.json b/plugins/woocommerce-beta-tester/package.json index c26a15055bb..4048ea2c53d 100644 --- a/plugins/woocommerce-beta-tester/package.json +++ b/plugins/woocommerce-beta-tester/package.json @@ -20,6 +20,7 @@ "uglify-js": "^3.5.3" }, "dependencies": { + "@types/prop-types": "^15.7.4", "@woocommerce/data": "workspace:*", "@wordpress/api-fetch": "^3.21.5", "@wordpress/components": "^12.0.7", diff --git a/plugins/woocommerce-beta-tester/src/admin-notes/add-note.js b/plugins/woocommerce-beta-tester/src/admin-notes/add-note.js index 42b0d0025e3..60def84f718 100644 --- a/plugins/woocommerce-beta-tester/src/admin-notes/add-note.js +++ b/plugins/woocommerce-beta-tester/src/admin-notes/add-note.js @@ -1,5 +1,5 @@ /** - * External dependencies. + * External dependencies */ import { useState } from '@wordpress/element'; import { Button, SelectControl } from '@wordpress/components'; diff --git a/plugins/woocommerce-beta-tester/src/admin-notes/admin-notes.js b/plugins/woocommerce-beta-tester/src/admin-notes/admin-notes.js index 048c877bc16..c15238cd101 100644 --- a/plugins/woocommerce-beta-tester/src/admin-notes/admin-notes.js +++ b/plugins/woocommerce-beta-tester/src/admin-notes/admin-notes.js @@ -1,5 +1,5 @@ /** - * Internal dependencies. + * Internal dependencies */ import { DeleteAllNotes } from './delete-all-notes'; import { AddNote } from './add-note'; diff --git a/plugins/woocommerce-beta-tester/src/admin-notes/delete-all-notes.js b/plugins/woocommerce-beta-tester/src/admin-notes/delete-all-notes.js index 3263bf5531c..0c15adc467d 100644 --- a/plugins/woocommerce-beta-tester/src/admin-notes/delete-all-notes.js +++ b/plugins/woocommerce-beta-tester/src/admin-notes/delete-all-notes.js @@ -1,5 +1,5 @@ /** - * External dependencies. + * External dependencies */ import { useState } from '@wordpress/element'; import { Button } from '@wordpress/components'; diff --git a/plugins/woocommerce-beta-tester/src/rest-api-filters/data/actions.js b/plugins/woocommerce-beta-tester/src/rest-api-filters/data/actions.js index c2c8c6fc0c1..68a61b9fe58 100644 --- a/plugins/woocommerce-beta-tester/src/rest-api-filters/data/actions.js +++ b/plugins/woocommerce-beta-tester/src/rest-api-filters/data/actions.js @@ -12,8 +12,7 @@ import { API_NAMESPACE } from './constants'; /** * Initialize the state * - * @param {Array} filter - * @param filters + * @param {Array} filters */ export function setFilters( filters ) { return { diff --git a/plugins/woocommerce-beta-tester/src/rest-api-filters/index.js b/plugins/woocommerce-beta-tester/src/rest-api-filters/index.js index 821da5869fc..67628d61b04 100644 --- a/plugins/woocommerce-beta-tester/src/rest-api-filters/index.js +++ b/plugins/woocommerce-beta-tester/src/rest-api-filters/index.js @@ -104,7 +104,7 @@ function RestAPIFilters( { >