Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13305 from woocommerce/fix-13304 

Fix unique sku function
This commit is contained in:
Claudio Sanches 2017-02-23 12:46:38 -03:00 committed by GitHub
parent 6f02cda453 4b4597524b
commit 22bb3071df
2 changed files with 35 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
includes/wc-product-functions.php
View File

@ -554,10 +554,9 @@ function wc_product_has_unique_sku( $product_id, $sku ) {
function wc_product_force_unique_sku( $product_id ) { function wc_product_force_unique_sku( $product_id ) {
$product = wc_get_product( $product_id ); $product = wc_get_product( $product_id );
if ( $product ) { if ( $product && ( $current_sku = $product->get_sku() ) ) {
try { try {
$current_sku = $product->get_sku(); $new_sku = wc_product_generate_unique_sku( $product_id, $current_sku );
$new_sku = wc_product_generate_unique_sku( $product_id, $current_sku );
if ( $current_sku !== $new_sku ) { if ( $current_sku !== $new_sku ) {
$product->set_sku( $new_sku ); $product->set_sku( $new_sku );

33
tests/unit-tests/product/functions.php
View File

@ -304,4 +304,37 @@ class WC_Tests_Product_Functions extends WC_Unit_Test_Case {
'type' => 'DECIMAL', 'type' => 'DECIMAL',
), $meta_query ); ), $meta_query );
} }
/**
* Test wc_product_force_unique_sku
*
* @since 2.7.0
*/
public function test_wc_product_force_unique_sku() {
$product_1 = WC_Helper_Product::create_simple_product();
$product_2 = WC_Helper_Product::create_simple_product();
$product_3 = WC_Helper_Product::create_simple_product();
$product_4 = WC_Helper_Product::create_simple_product();
$product_1->set_sku( 'some-custom-sku' );
$product_2->set_sku( 'another-custom-sku' );
$product_3->set_sku( 'another-custom-sku-1' );
$product_4->set_sku( '' );
$product_1_id = $product_1->save();
$product_2_id = $product_2->save();
$product_3_id = $product_3->save();
$product_4_id = $product_4->save();
wc_product_force_unique_sku( $product_4_id );
$this->assertEquals( get_post_meta( $product_4_id, '_sku', true ), '' );
update_post_meta( $product_4_id, '_sku', 'some-custom-sku' );
wc_product_force_unique_sku( $product_4_id );
$this->assertEquals( get_post_meta( $product_4_id, '_sku', true ), 'some-custom-sku-1' );
update_post_meta( $product_4_id, '_sku', 'another-custom-sku' );
wc_product_force_unique_sku( $product_4_id );
$this->assertEquals( get_post_meta( $product_4_id, '_sku', true ), 'another-custom-sku-2' );
}
} }