Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Define chunkFilename with contenthash in lazy loaded assets (https://github.com/woocommerce/woocommerce-blocks/pull/5094) 

* Define chunkFilename with contenthash

* Fix editor filename
This commit is contained in:
Mike Jolley 2021-11-09 15:10:47 +00:00 committed by GitHub
parent f36ec18bc2
commit 25e5ea7b51
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
plugins/woocommerce-blocks/bin/webpack-configs.js
View File

@ -171,12 +171,22 @@ const getMainConfig = ( options = {} ) => {
output: { output: {
devtoolNamespace: 'wc', devtoolNamespace: 'wc',
path: path.resolve( __dirname, '../build/' ), path: path.resolve( __dirname, '../build/' ),
// This is a cache busting mechanism which ensures that the script is loaded via the browser with a ?ver=hash
// string. The hash is based on the built file contents.
// @see https://github.com/webpack/webpack/issues/2329
// Using the ?ver string is needed here so the filename does not change between builds. The WordPress
// i18n system relies on the hash of the filename, so changing that frequently would result in broken
// translations which we must avoid.
// @see https://github.com/Automattic/jetpack/pull/20926
chunkFilename: `[name]${ fileSuffix }.js?ver=[contenthash]`,
filename: `[name]${ fileSuffix }.js`, filename: `[name]${ fileSuffix }.js`,
library: [ 'wc', 'blocks', '[name]' ], library: [ 'wc', 'blocks', '[name]' ],
libraryTarget: 'this', libraryTarget: 'this',
// This fixes an issue with multiple webpack projects using chunking // This fixes an issue with multiple webpack projects using chunking
// overwriting each other's chunk loader function. // overwriting each other's chunk loader function.
// See https://webpack.js.org/configuration/output/#outputjsonpfunction // See https://webpack.js.org/configuration/output/#outputjsonpfunction
// This can be removed when moving to webpack 5:
// https://webpack.js.org/blog/2020-10-10-webpack-5-release/#automatic-unique-naming
jsonpFunction: 'webpackWcBlocksJsonp', jsonpFunction: 'webpackWcBlocksJsonp',
}, },
module: { module: {
@ -280,10 +290,20 @@ const getFrontConfig = ( options = {} ) => {
output: { output: {
devtoolNamespace: 'wc', devtoolNamespace: 'wc',
path: path.resolve( __dirname, '../build/' ), path: path.resolve( __dirname, '../build/' ),
// This is a cache busting mechanism which ensures that the script is loaded via the browser with a ?ver=hash
// string. The hash is based on the built file contents.
// @see https://github.com/webpack/webpack/issues/2329
// Using the ?ver string is needed here so the filename does not change between builds. The WordPress
// i18n system relies on the hash of the filename, so changing that frequently would result in broken
// translations which we must avoid.
// @see https://github.com/Automattic/jetpack/pull/20926
chunkFilename: `[name]-frontend${ fileSuffix }.js?ver=[contenthash]`,
filename: `[name]-frontend${ fileSuffix }.js`, filename: `[name]-frontend${ fileSuffix }.js`,
// This fixes an issue with multiple webpack projects using chunking // This fixes an issue with multiple webpack projects using chunking
// overwriting each other's chunk loader function. // overwriting each other's chunk loader function.
// See https://webpack.js.org/configuration/output/#outputjsonpfunction // See https://webpack.js.org/configuration/output/#outputjsonpfunction
// This can be removed when moving to webpack 5:
// https://webpack.js.org/blog/2020-10-10-webpack-5-release/#automatic-unique-naming
jsonpFunction: 'webpackWcBlocksJsonp', jsonpFunction: 'webpackWcBlocksJsonp',
}, },
module: { module: {