From 28a6622b3babeb41720f602111e2438528f3e14a Mon Sep 17 00:00:00 2001 From: Joshua T Flowers Date: Thu, 18 Mar 2021 15:14:04 -0400 Subject: [PATCH] Delete customer data on network user deletion (https://github.com/woocommerce/woocommerce-admin/pull/6574) * Delete customer data on network user deletion * Add changelog entry and testing instructions --- plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md | 12 ++++++++++++ plugins/woocommerce-admin/readme.txt | 1 + .../src/Schedulers/CustomersScheduler.php | 1 + 3 files changed, 14 insertions(+) diff --git a/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md b/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md index 373a65e53c7..a669593ab5a 100644 --- a/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md +++ b/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md @@ -69,6 +69,18 @@ Testing `woocommerce_navigation_intro_modal_dismissed` 8. Attempt to directly visit the benefits page. `/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=benefits` 9. Note that you are redirected to the homescreen. +### Delete customer data on network user deletion #6574 + +1. Set up a multisite network. +2. Create a new user. +3. Make an order with that user. +4. Note the customer data under WooCommerce -> Customers. +5. Navigate to Network -> All users `/wp-admin/network/users.php`. +6. Delete that user. +7. Wait for the scheduled action to finish or manually run the `wc-admin_delete_user_customers` action under Tools -> Scheduled Actions. +8. Navigate to WooCommerce -> Customers. +9. Make sure that customer data has been deleted. + ### Fix hidden menu title on smaller screens #6562 1. Enable the new navigation. diff --git a/plugins/woocommerce-admin/readme.txt b/plugins/woocommerce-admin/readme.txt index e8701a475f0..ee64ab96d5e 100644 --- a/plugins/woocommerce-admin/readme.txt +++ b/plugins/woocommerce-admin/readme.txt @@ -79,6 +79,7 @@ Release and roadmap notes are available on the [WooCommerce Developers Blog](htt - Dev: Update undefined task name properties for help panel tracks #6565 - Fix: Allow the manager role to query certain options #6577 - Dev: Refactor profile wizard benefits step and add tests #6583 +- Fix: Delete customer data on network user deletion #6574 - Fix: Fix hidden menu title on smaller screens #6562 - Fix: Add gross sales column to CSV export #6567 - Dev: Add filter to profile wizard steps #6564 diff --git a/plugins/woocommerce-admin/src/Schedulers/CustomersScheduler.php b/plugins/woocommerce-admin/src/Schedulers/CustomersScheduler.php index 78e0800646d..6a513be56c6 100644 --- a/plugins/woocommerce-admin/src/Schedulers/CustomersScheduler.php +++ b/plugins/woocommerce-admin/src/Schedulers/CustomersScheduler.php @@ -30,6 +30,7 @@ class CustomersScheduler extends ImportScheduler { add_action( 'woocommerce_update_customer', array( __CLASS__, 'schedule_import' ) ); add_action( 'woocommerce_privacy_remove_order_personal_data', array( __CLASS__, 'schedule_anonymize' ) ); add_action( 'delete_user', array( __CLASS__, 'schedule_user_delete' ) ); + add_action( 'remove_user_from_blog', array( __CLASS__, 'schedule_user_delete' ) ); CustomersDataStore::init(); parent::init();