Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13812 from woocommerce/fix-13803 

Use new_* hooks instead of created_*
This commit is contained in:
Claudio Sanches 2017-03-28 15:19:41 -03:00 committed by GitHub
parent 407719559f 448d47a78c
commit 29d86dfea6
4 changed files with 35 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
includes/class-wc-deprecated-action-hooks.php
View File

@ -32,6 +32,8 @@ class WC_Deprecated_Action_Hooks extends WC_Deprecated_Hooks {
'woocommerce_order_update_fee',
'woocommerce_order_update_tax',
),
'woocommerce_new_payment_token' => 'woocommerce_payment_token_created',
'woocommerce_new_product_variation' => 'woocommerce_create_product_variation',
);
/**

2
includes/data-stores/class-wc-payment-token-data-store.php
View File

@ -61,7 +61,7 @@ class WC_Payment_Token_Data_Store extends WC_Data_Store_WP implements WC_Payment
WC_Payment_Tokens::set_users_default( $token->get_user_id(), $token_id );
}
do_action( 'woocommerce_payment_token_created', $token_id );
do_action( 'woocommerce_new_payment_token', $token_id );
}
/**

2
includes/data-stores/class-wc-product-variation-data-store-cpt.php
View File

@ -125,7 +125,7 @@ class WC_Product_Variation_Data_Store_CPT extends WC_Product_Data_Store_CPT impl
$this->clear_caches( $product );
do_action( 'woocommerce_create_product_variation', $id );
do_action( 'woocommerce_new_product_variation', $id );
}
}

41
tests/unit-tests/util/deprecated-hooks.php
View File

@ -10,7 +10,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
protected $handlers = array();
/**
* Generic toggle value function that can be hooked to a filter for testing
* Generic toggle value function that can be hooked to a filter for testing.
* @param bool/int $value
* @return bool/int
*/
@ -19,7 +19,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Generic toggle value function that can be hooked to an action for testing
* Generic toggle value function that can be hooked to an action for testing.
* @param bool/int $value
*/
function toggle_value_by_ref( &$value ) {
@ -27,7 +27,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Generic meta setting function that can be hooked to an action for testing
* Generic meta setting function that can be hooked to an action for testing.
* @param int $item1_id
* @param int $item2_id (default: false)
*/
@ -44,7 +44,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test the deprecated hook handlers are initialized
* Test the deprecated hook handlers are initialized.
*
* @since 3.0
*/
@ -57,7 +57,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test the get_old_hooks method
* Test the get_old_hooks method.
*
* @since 3.0
*/
@ -70,7 +70,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test the hook_in method
* Test the hook_in method.
*
* @since 3.0
*/
@ -80,7 +80,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test the handle_deprecated_hook method in the filters handler
* Test the handle_deprecated_hook method in the filters handler.
*
* @since 3.0
*/
@ -97,7 +97,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test the handle_deprecated_hook method in the actions handler
* Test the handle_deprecated_hook method in the actions handler.
*
* @since 3.0
*/
@ -115,7 +115,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test a complete deprecated filter mapping
* Test a complete deprecated filter mapping.
*
* @since 3.0
*/
@ -129,7 +129,7 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
}
/**
* Test a complete deprecated action mapping
* Test a complete deprecated action mapping.
*
* @since 3.0
*/
@ -150,4 +150,25 @@ class WC_Tests_Deprecated_Hooks extends WC_Unit_Test_Case {
$this->assertTrue( $order_update_worked );
$this->assertTrue( $item_update_worked );
}
/**
* Test the mapping of deprecated created_* hooks to new_* hooks.
*
* @since 3.0
*/
function test_created_actions_deprecation() {
add_filter( 'woocommerce_payment_token_created', '__return_true' );
add_filter( 'woocommerce_create_product_variation', '__return_true' );
$token = WC_Helper_Payment_Token::create_stub_token( __FUNCTION__ );
$token->save();
$product = new WC_Product_Variation;
$product->save();
$this->assertEquals( 1, did_action( 'woocommerce_payment_token_created' ) );
$this->assertEquals( 1, did_action( 'woocommerce_new_payment_token' ) );
$this->assertEquals( 1, did_action( 'woocommerce_create_product_variation' ) );
$this->assertEquals( 1, did_action( 'woocommerce_new_product_variation' ) );
}
}