useCollection hook: Do not bail early if isEditor (https://github.com/woocommerce/woocommerce-blocks/pull/8079)

This commit is contained in:
Patricia Hillebrandt 2023-01-10 15:17:51 +01:00 committed by GitHub
parent 8662d853f4
commit 2ddddbe50e
3 changed files with 1 additions and 15 deletions

View File

@ -171,6 +171,5 @@ export const useCollectionData = ( {
...collectionDataQueryVars,
},
shouldSelect: debouncedShouldSelect,
isEditor,
} );
};

View File

@ -5,7 +5,7 @@ import { COLLECTIONS_STORE_KEY as storeKey } from '@woocommerce/block-data';
import { useSelect } from '@wordpress/data';
import { useRef } from '@wordpress/element';
import { useShallowEqual, useThrowError } from '@woocommerce/base-hooks';
import { isError, isObject } from '@woocommerce/types';
import { isError } from '@woocommerce/types';
/**
* This is a custom hook that is wired up to the `wc/store/collections` data
@ -61,7 +61,6 @@ export const useCollection = (
resourceValues = [],
query = {},
shouldSelect = true,
isEditor = false,
} = options;
if ( ! namespace || ! resourceName ) {
throw new Error(
@ -79,17 +78,6 @@ export const useCollection = (
const throwError = useThrowError();
const results = useSelect(
( select ) => {
if (
isEditor &&
isObject( currentResults?.current?.results ) &&
Object.keys( currentResults.current.results ).length > 0
) {
return {
results: currentResults.current.results,
isLoading: false,
};
}
if ( ! shouldSelect ) {
return null;
}

View File

@ -138,7 +138,6 @@ const AttributeFilterBlock = ( {
resourceName: 'products/attributes/terms',
resourceValues: [ attributeObject?.id || 0 ],
shouldSelect: blockAttributes.attributeId > 0,
isEditor,
} );
const filterAvailableTerms =