Don't show Stock or Reviews panels before there are Products and/or Orders. (https://github.com/woocommerce/woocommerce-admin/pull/5973)

* Hide Stock and Reviews panels until there are products and/or orders.

* Add tests.

* Add to changelog.

plugins/woocommerce-admin/client/homescreen/activity-panel/index.js

@@ -27,6 +27,7 @@ export const ActivityPanel = () => {
 		const manageStock = getSetting( 'manageStock', 'no' );
 		const countLowStockProducts = getLowStockCount( select );
 		const countUnapprovedReviews = getUnapprovedReviews( select );
+		const publishedProductCount = getSetting( 'publishedProductCount', 0 );
 
 		return {
 			countLowStockProducts,
@@ -36,11 +37,16 @@ export const ActivityPanel = () => {
 			totalOrderCount,
 			reviewsEnabled,
 			countUnapprovedReviews,
+			publishedProductCount,
 		};
 	} );
 
 	const panels = getAllPanels( panelsData );
 
+	if ( panels.length === 0 ) {
+		return null;
+	}
+
 	return (
 		<Accordion>
 			<Fragment>

plugins/woocommerce-admin/client/homescreen/activity-panel/panels.js

@@ -12,12 +12,13 @@ import ReviewsPanel from './reviews';
 
 export function getAllPanels( {
 	countLowStockProducts,
+	countUnapprovedReviews,
 	countUnreadOrders,
 	manageStock,
 	orderStatuses,
-	totalOrderCount,
+	publishedProductCount,
 	reviewsEnabled,
-	countUnapprovedReviews,
+	totalOrderCount,
 } ) {
 	return [
 		totalOrderCount > 0 && {
@@ -34,30 +35,35 @@ export function getAllPanels( {
 			),
 			title: __( 'Orders', 'woocommerce-admin' ),
 		},
-		manageStock === 'yes' && {
-			className: 'woocommerce-homescreen-card',
-			count: countLowStockProducts,
-			id: 'stock-panel',
-			initialOpen: false,
-			collapsible: countLowStockProducts !== 0,
-			panel: (
-				<StockPanel countLowStockProducts={ countLowStockProducts } />
-			),
-			title: __( 'Stock', 'woocommerce-admin' ),
-		},
-		reviewsEnabled === 'yes' && {
-			className: 'woocommerce-homescreen-card',
-			id: 'reviews-panel',
-			count: countUnapprovedReviews,
-			initialOpen: false,
-			collapsible: countUnapprovedReviews !== 0,
-			panel: (
-				<ReviewsPanel
-					hasUnapprovedReviews={ countUnapprovedReviews > 0 }
-				/>
-			),
-			title: __( 'Reviews', 'woocommerce-admin' ),
-		},
+		totalOrderCount > 0 &&
+			publishedProductCount > 0 &&
+			manageStock === 'yes' && {
+				className: 'woocommerce-homescreen-card',
+				count: countLowStockProducts,
+				id: 'stock-panel',
+				initialOpen: false,
+				collapsible: countLowStockProducts !== 0,
+				panel: (
+					<StockPanel
+						countLowStockProducts={ countLowStockProducts }
+					/>
+				),
+				title: __( 'Stock', 'woocommerce-admin' ),
+			},
+		publishedProductCount > 0 &&
+			reviewsEnabled === 'yes' && {
+				className: 'woocommerce-homescreen-card',
+				id: 'reviews-panel',
+				count: countUnapprovedReviews,
+				initialOpen: false,
+				collapsible: countUnapprovedReviews !== 0,
+				panel: (
+					<ReviewsPanel
+						hasUnapprovedReviews={ countUnapprovedReviews > 0 }
+					/>
+				),
+				title: __( 'Reviews', 'woocommerce-admin' ),
+			},
 		// Add another panel row here
 	].filter( Boolean );
 }

plugins/woocommerce-admin/client/homescreen/activity-panel/test/panels.js

@@ -4,11 +4,13 @@
 import { getAllPanels } from '../panels';
 
 describe( 'ActivityPanel', () => {
-	it( 'should exclude the orders panel when there are no orders', () => {
+	it( 'should exclude the orders and stock panels when there are no orders', () => {
 		const panels = getAllPanels( {
 			countUnreadOrders: 0,
 			orderStatuses: [],
 			totalOrderCount: 0,
+			publishedProductCount: 1,
+			manageStock: 'yes',
 		} );
 
 		expect( panels ).toEqual(
@@ -16,6 +18,33 @@ describe( 'ActivityPanel', () => {
 				expect.objectContaining( { id: 'orders-panel' } ),
 			] )
 		);
+		expect( panels ).toEqual(
+			expect.not.arrayContaining( [
+				expect.objectContaining( { id: 'stock-panel' } ),
+			] )
+		);
+	} );
+
+	it( 'should exclude the reviews and stock panels when there are no published products', () => {
+		const panels = getAllPanels( {
+			countUnreadOrders: 0,
+			orderStatuses: [],
+			totalOrderCount: 1, // Yes, I realize this isn't "possible".
+			publishedProductCount: 0,
+			manageStock: 'yes',
+			reviewsEnabled: 'yes',
+		} );
+
+		expect( panels ).toEqual(
+			expect.not.arrayContaining( [
+				expect.objectContaining( { id: 'reviews-panel' } ),
+			] )
+		);
+		expect( panels ).toEqual(
+			expect.not.arrayContaining( [
+				expect.objectContaining( { id: 'stock-panel' } ),
+			] )
+		);
 	} );
 
 	it( 'should include the orders panel when there are orders', () => {
@@ -31,4 +60,33 @@ describe( 'ActivityPanel', () => {
 			] )
 		);
 	} );
+
+	it( 'should include the stock panel when there are orders, products, and inventory management is enabled', () => {
+		const panels = getAllPanels( {
+			countUnreadOrders: 1,
+			orderStatuses: [],
+			totalOrderCount: 10,
+			publishedProductCount: 2,
+			manageStock: 'yes',
+		} );
+
+		expect( panels ).toEqual(
+			expect.arrayContaining( [
+				expect.objectContaining( { id: 'stock-panel' } ),
+			] )
+		);
+	} );
+
+	it( 'should include the reviews panel when there are products and reviews are enabled', () => {
+		const panels = getAllPanels( {
+			publishedProductCount: 5,
+			reviewsEnabled: 'yes',
+		} );
+
+		expect( panels ).toEqual(
+			expect.arrayContaining( [
+				expect.objectContaining( { id: 'reviews-panel' } ),
+			] )
+		);
+	} );
 } );

plugins/woocommerce-admin/readme.txt

@@ -90,6 +90,7 @@ Release and roadmap notes are available on the [WooCommerce Developers Blog](htt
 - Fix: Product exclusion filter on Orders Report.
 - Fix: Typo in Variation Stats DataStore context filter value.
 - Fix: support custom attributes in Attribute advanced report filter.
+- Fix: Don't show Stock and Reviews Homescreen panels too early.
 
 == 1.8.2 12/22/2020 ==
 

plugins/woocommerce-admin/src/Features/Homescreen.php

@@ -148,8 +148,10 @@ class Homescreen {
 		// Remove the Draft Order status (from the Checkout Block).
 		unset( $allowed_statuses['checkout-draft'] );
 
-		$status_counts          = array_map( 'wc_orders_count', array_keys( $allowed_statuses ) );
-		$settings['orderCount'] = array_sum( $status_counts );
+		$status_counts                     = array_map( 'wc_orders_count', array_keys( $allowed_statuses ) );
+		$product_counts                    = wp_count_posts( 'product' );
+		$settings['orderCount']            = array_sum( $status_counts );
+		$settings['publishedProductCount'] = $product_counts->publish;
 
 		return $settings;
 	}