Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add a conditional to match `inc_usage_count()` 

Otherwise, for empty $used_by values, it will fire off a needless db
query.
This commit is contained in:
George Stephanis 2015-08-24 14:20:30 -04:00
parent 40dfb59bde
commit 4692afacdd
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
includes/class-wc-coupon.php
View File

@ -271,13 +271,15 @@ class WC_Coupon {
$this->usage_count--;
update_post_meta( $this->id, 'usage_count', $this->usage_count );
/**
* We're doing this the long way because `delete_post_meta( $id, $key, $value )` deletes
* all instances where the key and value match, and we only want to delete one.
*/
$meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE meta_key = '_used_by' AND meta_value = %s AND post_id = %d LIMIT 1;", $used_by, $this->id ) );
if ( $meta_id ) {
delete_metadata_by_mid( 'post', $meta_id );
if ( $used_by ) {
/**
* We're doing this the long way because `delete_post_meta( $id, $key, $value )` deletes
* all instances where the key and value match, and we only want to delete one.
*/
$meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE meta_key = '_used_by' AND meta_value = %s AND post_id = %d LIMIT 1;", $used_by, $this->id ) );
if ( $meta_id ) {
delete_metadata_by_mid( 'post', $meta_id );
}
}
}
}