Remove attributes data from save function for active filters (https://github.com/woocommerce/woocommerce-blocks/pull/10047)

This commit is contained in:
Roy Ho 2023-07-03 06:52:31 -07:00 committed by GitHub
parent f8cf9fe97a
commit 48f7a9fdda
2 changed files with 48 additions and 7 deletions

View File

@ -0,0 +1,45 @@
/**
* External dependencies
*/
import { useBlockProps } from '@wordpress/block-editor';
import classNames from 'classnames';
/**
* Internal dependencies
*/
import { blockAttributes } from './attributes';
import metadata from './block.json';
import { Attributes } from './types';
const v1 = {
attributes: {
...metadata.attributes,
...blockAttributes,
},
save: ( { attributes }: { attributes: Attributes } ) => {
const { className, displayStyle, heading, headingLevel } = attributes;
const data = {
'data-display-style': displayStyle,
'data-heading': heading,
'data-heading-level': headingLevel,
};
return (
<div
{ ...useBlockProps.save( {
className: classNames( 'is-loading', className ),
} ) }
{ ...data }
>
<span
aria-hidden
className="wc-block-active-filters__placeholder"
/>
</div>
);
},
};
const deprecated = [ v1 ];
export default deprecated;

View File

@ -14,6 +14,7 @@ import edit from './edit';
import metadata from './block.json';
import { blockAttributes } from './attributes';
import { Attributes } from './types';
import deprecated from './deprecated';
registerBlockType( metadata, {
icon: {
@ -31,19 +32,13 @@ registerBlockType( metadata, {
edit,
// Save the props to post content.
save( { attributes }: { attributes: Attributes } ) {
const { className, displayStyle, heading, headingLevel } = attributes;
const data = {
'data-display-style': displayStyle,
'data-heading': heading,
'data-heading-level': headingLevel,
};
const { className } = attributes;
return (
<div
{ ...useBlockProps.save( {
className: classNames( 'is-loading', className ),
} ) }
{ ...data }
>
<span
aria-hidden
@ -52,4 +47,5 @@ registerBlockType( metadata, {
</div>
);
},
deprecated,
} );