Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add "aria-disabled" prop to truly disable OBW continue buttons (#34895) 

* Add aria-disabled prop to truly disable OBW continue buttons

* Add changelog
This commit is contained in:
Chi-Hsuan Huang 2022-10-03 16:32:23 +08:00 committed by GitHub
parent c46f4baa49
commit 4a39091961
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/woocommerce-admin/client/profile-wizard/steps/business-details/flows/selective-bundle/index.js
View File

@ -627,6 +627,7 @@ class BusinessDetails extends Component {
this.persistProfileItems();
} }
disabled={ ! isValidForm }
aria-disabled={ ! isValidForm }
isBusy={ isInstallingActivating }
>
{ ! hasInstallActivateError

3
plugins/woocommerce-admin/client/profile-wizard/steps/industry.js
View File

@ -291,6 +291,9 @@ class Industry extends Component {
disabled={
! selected.length || isProfileItemsRequesting
}
aria-disabled={
! selected.length || isProfileItemsRequesting
}
>
{ __( 'Continue', 'woocommerce' ) }
</Button>

5
plugins/woocommerce-admin/client/profile-wizard/steps/product-types/index.js
View File

@ -286,6 +286,11 @@ export class ProductTypes extends Component {
isProfileItemsRequesting ||
isInstallingActivating
}
aria-disabled={
! selected.length ||
isProfileItemsRequesting ||
isInstallingActivating
}
>
{ __( 'Continue', 'woocommerce' ) }
</Button>

2
plugins/woocommerce-admin/client/profile-wizard/steps/product-types/test/__snapshots__/index.js.snap
View File

@ -128,6 +128,7 @@ you can purchase and install it later.
data-wp-component="CardFooter"
>
<button
aria-disabled="true"
class="components-button is-primary"
disabled=""
type="button"
@ -323,6 +324,7 @@ you can purchase and install it later.
data-wp-component="CardFooter"
>
<button
aria-disabled="true"
class="components-button is-primary"
disabled=""
type="button"

1
plugins/woocommerce-admin/client/profile-wizard/steps/store-details/index.js
View File

@ -376,6 +376,7 @@ export class StoreDetails extends Component {
onClick={ handleSubmit }
isBusy={ isBusy }
disabled={ ! isValidForm || isBusy }
aria-disabled={ ! isValidForm || isBusy }
>
{ __( 'Continue', 'woocommerce' ) }
</Button>

2
plugins/woocommerce-admin/client/profile-wizard/steps/store-details/test/__snapshots__/index.js.snap
View File

@ -288,6 +288,7 @@ Object {
data-wp-component="CardFooter"
>
<button
aria-disabled="true"
class="components-button is-primary"
disabled=""
type="button"
@ -601,6 +602,7 @@ Object {
data-wp-component="CardFooter"
>
<button
aria-disabled="true"
class="components-button is-primary"
disabled=""
type="button"

4
plugins/woocommerce/changelog/fix-33986-obw-validation-issue Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: fix
Fix obw validation issue to truly disable the continue buttons