From 990af1f5343f9ec73afee062d1938fe653e4b0f5 Mon Sep 17 00:00:00 2001 From: Gan Eng Chin Date: Thu, 6 Jul 2023 23:50:56 +0800 Subject: [PATCH 1/2] Rename "Install plugin" button text to "Install extension". --- .../components/PluginCardBody/SmartPluginCardBody.tsx | 2 +- .../DiscoverTools/DiscoverTools.test.tsx | 8 +++++--- .../DiscoverTools/PluginsTabPanel.tsx | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/plugins/woocommerce-admin/client/marketing/components/PluginCardBody/SmartPluginCardBody.tsx b/plugins/woocommerce-admin/client/marketing/components/PluginCardBody/SmartPluginCardBody.tsx index 76cf16f01aa..0ce265fd033 100644 --- a/plugins/woocommerce-admin/client/marketing/components/PluginCardBody/SmartPluginCardBody.tsx +++ b/plugins/woocommerce-admin/client/marketing/components/PluginCardBody/SmartPluginCardBody.tsx @@ -95,7 +95,7 @@ export const SmartPluginCardBody = ( { disabled={ buttonDisabled } onClick={ installAndActivate } > - { __( 'Install plugin', 'woocommerce' ) } + { __( 'Install extension', 'woocommerce' ) } ); } diff --git a/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/DiscoverTools.test.tsx b/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/DiscoverTools.test.tsx index 18ada3a3c24..f173ea50638 100644 --- a/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/DiscoverTools.test.tsx +++ b/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/DiscoverTools.test.tsx @@ -58,7 +58,7 @@ describe( 'DiscoverTools component', () => { } ); describe( 'With plugins loaded', () => { - it( 'should render `direct_install: true` plugins with "Install plugin" button', () => { + it( 'should render `direct_install: true` plugins with "Install extension" button', () => { ( useRecommendedPluginsWithoutChannels as jest.Mock ).mockReturnValue( { @@ -92,7 +92,7 @@ describe( 'DiscoverTools component', () => { } ); render( ); - // Assert that we have the "Sales channels" tab, the plugin name, the "Built by WooCommerce" pill, and the "Install plugin" button. + // Assert that we have the "Sales channels" tab, the plugin name, the "Built by WooCommerce" pill, and the "Install extension" button. expect( screen.getByText( 'Sales channels' ) ).toBeInTheDocument(); expect( screen.getByText( 'Google Listings and Ads' ) @@ -100,7 +100,9 @@ describe( 'DiscoverTools component', () => { expect( screen.getByText( 'Built by WooCommerce' ) ).toBeInTheDocument(); - expect( screen.getByText( 'Install plugin' ) ).toBeInTheDocument(); + expect( + screen.getByText( 'Install extension' ) + ).toBeInTheDocument(); } ); it( 'should render `direct_install: false` plugins with "View details" button', () => { diff --git a/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/PluginsTabPanel.tsx b/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/PluginsTabPanel.tsx index 902bbc8a02e..2d63f72edab 100644 --- a/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/PluginsTabPanel.tsx +++ b/plugins/woocommerce-admin/client/marketing/overview-multichannel/DiscoverTools/PluginsTabPanel.tsx @@ -117,7 +117,7 @@ export const PluginsTabPanel = ( { installAndActivate( plugin ); } } > - { __( 'Install plugin', 'woocommerce' ) } + { __( 'Install extension', 'woocommerce' ) } ); } From a2f2d135b2a9b67accb36dc55d94b1a4c6ceecf2 Mon Sep 17 00:00:00 2001 From: Gan Eng Chin Date: Fri, 7 Jul 2023 01:01:03 +0800 Subject: [PATCH 2/2] Add changelog. --- .../changelog/fix-39103-install-extension-button-text | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 plugins/woocommerce/changelog/fix-39103-install-extension-button-text diff --git a/plugins/woocommerce/changelog/fix-39103-install-extension-button-text b/plugins/woocommerce/changelog/fix-39103-install-extension-button-text new file mode 100644 index 00000000000..fefa9c2e105 --- /dev/null +++ b/plugins/woocommerce/changelog/fix-39103-install-extension-button-text @@ -0,0 +1,4 @@ +Significance: minor +Type: update + +Change button text from "Install plugin" to "Install extension" in Marketing page.