From 4b3df7732b74a92aebbf740ff211ef293751ec40 Mon Sep 17 00:00:00 2001 From: Joshua T Flowers Date: Tue, 15 Jan 2019 10:13:15 +0800 Subject: [PATCH] Add showMenu prop to TableCard to hide ellipsis menu (https://github.com/woocommerce/woocommerce-admin/pull/1296) * Add showMenu prop to TableCard to hide ellipsis menu * Fix proptype description --- .../client/analytics/components/leaderboard/index.js | 1 + .../packages/components/src/table/index.js | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/plugins/woocommerce-admin/client/analytics/components/leaderboard/index.js b/plugins/woocommerce-admin/client/analytics/components/leaderboard/index.js index d6591c0746a..439b62cbf95 100644 --- a/plugins/woocommerce-admin/client/analytics/components/leaderboard/index.js +++ b/plugins/woocommerce-admin/client/analytics/components/leaderboard/index.js @@ -57,6 +57,7 @@ export class Leaderboard extends Component { isLoading={ isRequesting } rows={ rows } rowsPerPage={ totalRows } + showMenu={ false } title={ title } totalRows={ totalRows } /> diff --git a/plugins/woocommerce-admin/packages/components/src/table/index.js b/plugins/woocommerce-admin/packages/components/src/table/index.js index 4531dc2fa00..02e8ae83b26 100644 --- a/plugins/woocommerce-admin/packages/components/src/table/index.js +++ b/plugins/woocommerce-admin/packages/components/src/table/index.js @@ -237,6 +237,7 @@ class TableCard extends Component { rowsPerPage, searchBy, searchParam, + showMenu, summary, title, totalRows, @@ -301,7 +302,7 @@ class TableCard extends Component { ), ] } menu={ - + showMenu && { __( 'Columns:', 'wc-admin' ) } { allHeaders.map( ( { key, label, required } ) => { if ( required ) { @@ -441,6 +442,10 @@ TableCard.propTypes = { * Url query parameter search function operates on */ searchParam: PropTypes.string, + /** + * Boolean to determine whether or not ellipsis menu is shown. + */ + showMenu: PropTypes.bool, /** * An array of objects with `label` & `value` properties, which display in a line under the table. * Optional, can be left off to show no summary. @@ -470,6 +475,7 @@ TableCard.defaultProps = { query: {}, rowHeader: 0, rows: [], + showMenu: true, }; export default TableCard;