Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16575 from woocommerce/fix/arraysubsettest 

Harden + fix plugin updates tests
This commit is contained in:
Mike Jolley 2017-08-23 11:02:06 +01:00 committed by GitHub
parent 22813663d7 b8af7164db
commit 4c2c051773
1 changed files with 55 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
tests/unit-tests/util/plugin-updates.php
View File

@ -58,19 +58,19 @@ class WC_Tests_Plugin_Updates extends WC_Unit_Test_Case {
$this->plugins = array(
'test/test.php' => array(
'Name' => 'Test plugin',
'Name' => 'Test plugin',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.0.0',
),
'test2/test2.php' => array(
'Name' => 'Test plugin 2',
'Name' => 'Test plugin 2',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '5.0',
),
'test3/test3.php' => array(
'Name' => 'Test plugin 3',
'Name' => 'Test plugin 3',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.1.0',
),
'test4/test4.php' => array(
'Name' => 'Test plugin 4',
'Name' => 'Test plugin 4',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.0.1',
),
);
@ -113,26 +113,31 @@ class WC_Tests_Plugin_Updates extends WC_Unit_Test_Case {
$this->plugins = array(
'test/test.php' => array(
'Name' => 'Test plugin',
'Name' => 'Test plugin',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '3.0.0',
),
'test2/test2.php' => array(
'Name' => 'Test plugin 2',
'Name' => 'Test plugin 2',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '3.9.9',
),
'test3/test3.php' => array(
'Name' => 'Test plugin 3',
'Name' => 'Test plugin 3',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '3.0',
),
);
$plugin_keys = array_keys( $this->plugins );
$new_version = '4.0.0';
$this->assertArraySubset( $this->plugins, $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
$new_version = '4.3.0';
$this->assertArraySubset( $this->plugins, $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
$new_version = '4.0.2';
$this->assertArraySubset( $this->plugins, $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
}
/**
@ -145,30 +150,42 @@ class WC_Tests_Plugin_Updates extends WC_Unit_Test_Case {
$this->plugins = array(
'test/test.php' => array(
'Name' => 'Test plugin',
'Name' => 'Test plugin',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.1.0',
),
'test2/test2.php' => array(
'Name' => 'Test plugin 2',
'Name' => 'Test plugin 2',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '5.0.0',
),
'test3/test3.php' => array(
'Name' => 'Test plugin 3',
'Name' => 'Test plugin 3',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.1.1',
),
'test4/test4.php' => array(
'Name' => 'Test plugin 4',
'Name' => 'Test plugin 4',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.2.1',
),
);
$new_version = '4.1.0';
$this->assertEquals( array(), $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertArrayNotHasKey( 'test/test.php', $untested );
$this->assertArrayNotHasKey( 'test2/test2.php', $untested );
$this->assertArrayNotHasKey( 'test3/test3.php', $untested );
$this->assertArrayNotHasKey( 'test4/test4.php', $untested );
$new_version = '4.2.0';
$this->assertEquals( 2, count( $this->updates->get_untested_plugins( $new_version, $release ) ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertArrayHasKey( 'test/test.php', $untested );
$this->assertArrayNotHasKey( 'test2/test2.php', $untested );
$this->assertArrayHasKey( 'test3/test3.php', $untested );
$this->assertArrayNotHasKey( 'test4/test4.php', $untested );
$new_version = '4.1.5';
$this->assertEquals( array(), $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertArrayNotHasKey( 'test/test.php', $untested );
$this->assertArrayNotHasKey( 'test2/test2.php', $untested );
$this->assertArrayNotHasKey( 'test3/test3.php', $untested );
$this->assertArrayNotHasKey( 'test4/test4.php', $untested );
}
/**
@ -181,29 +198,33 @@ class WC_Tests_Plugin_Updates extends WC_Unit_Test_Case {
$this->plugins = array(
'test/test.php' => array(
'Name' => 'Test plugin',
'Name' => 'Test plugin',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.1.0',
),
'test2/test2.php' => array(
'Name' => 'Test plugin 2',
'Name' => 'Test plugin 2',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '3.9.0',
),
'test3/test3.php' => array(
'Name' => 'Test plugin 3',
'Name' => 'Test plugin 3',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4.2',
),
);
$plugin_keys = array_keys( $this->plugins );
$new_version = '4.3.0';
$this->assertEquals( $this->plugins, $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
$new_version = '4.3.1';
$this->assertEquals( $this->plugins, $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertEquals( $plugin_keys, array_intersect( $plugin_keys, array_keys( $untested ) ) );
$new_version = '4.1.0';
$this->assertEquals( array( 'test2/test2.php' => $this->plugins['test2/test2.php'] ), $this->updates->get_untested_plugins( $new_version, $release ) );
$this->assertArrayHasKey( 'test2/test2.php', $this->updates->get_untested_plugins( $new_version, $release ) );
$new_version = '4.1.5';
$this->assertEquals( array( 'test2/test2.php' => $this->plugins['test2/test2.php'] ), $this->updates->get_untested_plugins( $new_version, $release ) );
$this->assertArrayHasKey( 'test2/test2.php', $this->updates->get_untested_plugins( $new_version, $release ) );
}
/**
@ -217,29 +238,33 @@ class WC_Tests_Plugin_Updates extends WC_Unit_Test_Case {
$this->plugins = array(
'test/test.php' => array(
'Name' => 'Test plugin',
'Name' => 'Test plugin',
WC_Plugin_Updates::VERSION_TESTED_HEADER => '4',
),
'test2/test2.php' => array(
'Name' => 'Test plugin 2',
'Name' => 'Test plugin 2',
WC_Plugin_Updates::VERSION_TESTED_HEADER => 'Latest release',
),
'test3/test3.php' => array(
'Name' => 'Test plugin 3',
'Name' => 'Test plugin 3',
WC_Plugin_Updates::VERSION_TESTED_HEADER => 'WC 3.0.0',
),
'test4/test4.php' => array(
'Name' => 'Test plugin 4',
'Name' => 'Test plugin 4',
WC_Plugin_Updates::VERSION_TESTED_HEADER => ' ',
),
);
$release = 'major';
$new_version = '5.0.0';
$this->assertArraySubset( array( 'test/test.php' => $this->plugins['test/test.php'] ), $this->updates->get_untested_plugins( $new_version, $release ) );
$this->assertArrayHasKey( 'test/test.php', $this->updates->get_untested_plugins( $new_version, $release ) );
$release = 'minor';
$new_version = '4.1.0';
$this->assertEquals( array(), $this->updates->get_untested_plugins( $new_version, $release ) );
$untested = $this->updates->get_untested_plugins( $new_version, $release );
$this->assertArrayNotHasKey( 'test/test.php', $untested );
$this->assertArrayNotHasKey( 'test2/test2.php', $untested );
$this->assertArrayNotHasKey( 'test3/test3.php', $untested );
$this->assertArrayNotHasKey( 'test4/test4.php', $untested );
}
}