Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13532 from woocommerce/fix/order-item-meta-cache 

Fix order item meta functions cache busting.
This commit is contained in:
Mike Jolley 2017-03-10 11:47:26 +00:00 committed by GitHub
parent 58e4e318b0 9724b67ab8
commit 4f1c433fbf
2 changed files with 68 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
includes/wc-order-item-functions.php
View File

@ -98,8 +98,8 @@ function wc_delete_order_item( $item_id ) {
function wc_update_order_item_meta( $item_id, $meta_key, $meta_value, $prev_value = '' ) { function wc_update_order_item_meta( $item_id, $meta_key, $meta_value, $prev_value = '' ) {
$data_store = WC_Data_Store::load( 'order-item' ); $data_store = WC_Data_Store::load( 'order-item' );
if ( $data_store->update_metadata( $item_id, $meta_key, $meta_value, $prev_value ) ) { if ( $data_store->update_metadata( $item_id, $meta_key, $meta_value, $prev_value ) ) {
$cache_key = WC_Cache_Helper::get_cache_prefix( 'orders' ) . 'item_meta_array_' . $item_id; $cache_key = WC_Cache_Helper::get_cache_prefix( 'order-items' ) . 'object_meta_' . $item_id;
wp_cache_delete( $cache_key, 'orders' ); wp_cache_delete( $cache_key, 'order-items' );
return true; return true;
} }
return false; return false;
@ -118,8 +118,8 @@ function wc_update_order_item_meta( $item_id, $meta_key, $meta_value, $prev_valu
function wc_add_order_item_meta( $item_id, $meta_key, $meta_value, $unique = false ) { function wc_add_order_item_meta( $item_id, $meta_key, $meta_value, $unique = false ) {
$data_store = WC_Data_Store::load( 'order-item' ); $data_store = WC_Data_Store::load( 'order-item' );
if ( $meta_id = $data_store->add_metadata( $item_id, $meta_key, $meta_value, $unique ) ) { if ( $meta_id = $data_store->add_metadata( $item_id, $meta_key, $meta_value, $unique ) ) {
$cache_key = WC_Cache_Helper::get_cache_prefix( 'orders' ) . 'item_meta_array_' . $item_id; $cache_key = WC_Cache_Helper::get_cache_prefix( 'order-items' ) . 'object_meta_' . $item_id;
wp_cache_delete( $cache_key, 'orders' ); wp_cache_delete( $cache_key, 'order-items' );
return $meta_id; return $meta_id;
} }
return 0; return 0;
@ -138,8 +138,8 @@ function wc_add_order_item_meta( $item_id, $meta_key, $meta_value, $unique = fal
function wc_delete_order_item_meta( $item_id, $meta_key, $meta_value = '', $delete_all = false ) { function wc_delete_order_item_meta( $item_id, $meta_key, $meta_value = '', $delete_all = false ) {
$data_store = WC_Data_Store::load( 'order-item' ); $data_store = WC_Data_Store::load( 'order-item' );
if ( $data_store->delete_metadata( $item_id, $meta_key, $meta_value, $delete_all ) ) { if ( $data_store->delete_metadata( $item_id, $meta_key, $meta_value, $delete_all ) ) {
$cache_key = WC_Cache_Helper::get_cache_prefix( 'orders' ) . 'item_meta_array_' . $item_id; $cache_key = WC_Cache_Helper::get_cache_prefix( 'order-items' ) . 'object_meta_' . $item_id;
wp_cache_delete( $cache_key, 'orders' ); wp_cache_delete( $cache_key, 'order-items' );
return true; return true;
} }
return false; return false;

62
tests/unit-tests/order-items/functions.php Normal file
View File

@ -0,0 +1,62 @@
<?php
/**
* Order Item Function Tests
* @package WooCommerce\Tests\Order_Items
* @since 2.7.0
*/
class WC_Tests_Order_Item_Functions extends WC_Unit_Test_Case {
/**
* test_wc_order_item_meta_functions
*
* wc_add_order_item_meta, wc_update_order_item_meta, and
* wc_delete_order_item_meta all make direct updates through
* a datastore. These tests make sure cache is properly busted and
* accessing those values via CRUD returns the correct value.
*
* @since 2.7.0
*/
function test_wc_order_item_meta_functions() {
$meta_value = 'cat';
$meta_value2 = 'dog';
$order = new WC_Order();
$item_1 = new WC_Order_Item_Product();
$item_1->set_props( array(
'product' => WC_Helper_Product::create_simple_product(),
'quantity' => 4,
) );
$order->add_item( $item_1 );
$order->save();
$item = current( $order->get_items() );
$item_id = $item->get_id();
// Test that the initial key doesn't exist.
$item = new WC_Order_Item_Product( $item_id );;
$this->assertEmpty( $item->get_meta( '_test_key' ) );
$this->assertEmpty( wc_get_order_item_meta( $item_id, '_test_key' ) );
// Test making sure cache is properly busted when adding meta.
wc_add_order_item_meta( $item_id, '_test_key', $meta_value );
$item = new WC_Order_Item_Product( $item_id );
$item_meta = $item->get_meta( '_test_key' );
$this->assertEquals( $meta_value, $item_meta );
$this->assertEquals( $meta_value, wc_get_order_item_meta( $item_id, '_test_key' ) );
// Test making sure cache is properly busted when updating meta.
wc_update_order_item_meta( $item_id, '_test_key', $meta_value2 );
$item = new WC_Order_Item_Product( $item_id );
$item_meta = $item->get_meta( '_test_key' );
$this->assertEquals( $meta_value2, $item_meta );
$this->assertEquals( $meta_value2, wc_get_order_item_meta( $item_id, '_test_key' ) );
// Test making sure cache is properly busted when deleting meta.
wc_delete_order_item_meta( $item_id, '_test_key' );
$item = new WC_Order_Item_Product( $item_id );
$item_meta = $item->get_meta( '_test_key' );
$this->assertEmpty( $item->get_meta( '_test_key' ) );
$this->assertEmpty( wc_get_order_item_meta( $item_id, '_test_key' ) );
}
}