From 5002a1498ae1ab9cf5ae59abfdf6252f494df851 Mon Sep 17 00:00:00 2001 From: Jacob Sewell Date: Mon, 31 Jan 2022 15:56:15 -0600 Subject: [PATCH] Fix distorted Country/Region label at some zoom levels (https://github.com/woocommerce/woocommerce-admin/pull/8186) * Override overflow rule for label in select controls in OBW store address inputs. * Changelog for 7893/8186. * Rather than specifically override the overflow for store addresss country/region, remove the specific rule that was causing the issue. * Increase line-height on SelectControl label. * Restore overflow: hidden rule for profile wizard control label. * Update changelog for 7893/8186. * Add package changelog entry for 7893/8186. --- .../changelogs/fix-7893-country-input-label-distorted | 4 ++++ plugins/woocommerce-admin/packages/components/CHANGELOG.md | 2 ++ .../packages/components/src/select-control/style.scss | 1 + 3 files changed, 7 insertions(+) create mode 100644 plugins/woocommerce-admin/changelogs/fix-7893-country-input-label-distorted diff --git a/plugins/woocommerce-admin/changelogs/fix-7893-country-input-label-distorted b/plugins/woocommerce-admin/changelogs/fix-7893-country-input-label-distorted new file mode 100644 index 00000000000..59c77319258 --- /dev/null +++ b/plugins/woocommerce-admin/changelogs/fix-7893-country-input-label-distorted @@ -0,0 +1,4 @@ +Significance: patch +Type: Tweak + +OBW: Override Country/Region label line-height style to avoid truncated descenders. #8186 diff --git a/plugins/woocommerce-admin/packages/components/CHANGELOG.md b/plugins/woocommerce-admin/packages/components/CHANGELOG.md index 1f84fb79ab7..015932d5e69 100644 --- a/plugins/woocommerce-admin/packages/components/CHANGELOG.md +++ b/plugins/woocommerce-admin/packages/components/CHANGELOG.md @@ -1,5 +1,7 @@ # Unreleased +- Update line-height of SelectControl label to avoid truncated descenders in some typefaces and zoom levels. #8186 + # 8.2.0 - Fix usage of Wordpress DatePicker component in `DatePicker`. #7982 diff --git a/plugins/woocommerce-admin/packages/components/src/select-control/style.scss b/plugins/woocommerce-admin/packages/components/src/select-control/style.scss index fec34879487..fc870497a8a 100644 --- a/plugins/woocommerce-admin/packages/components/src/select-control/style.scss +++ b/plugins/woocommerce-admin/packages/components/src/select-control/style.scss @@ -33,6 +33,7 @@ transform: translateY(-50%); color: $studio-gray-50; font-size: 16px; + line-height: 1.5em; } .woocommerce-select-control__control-input {