Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unused task styling classes (https://github.com/woocommerce/woocommerce-admin/pull/8234) 

* Remove unused task styling classes

* Rename typo in dismiss modals

* Remove extra styling selector class

* Add changelog entry
This commit is contained in:
Joshua T Flowers 2022-02-04 10:26:56 -05:00 committed by GitHub
parent e8c1c94b01
commit 517d248ed7
8 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce-admin/changelogs/fix-7693 Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: Dev
Remove unused task styling classes #8234

4
plugins/woocommerce-admin/client/inbox-panel/dissmiss-all-modal.js → plugins/woocommerce-admin/client/inbox-panel/dismiss-all-modal.js
View File

@ -7,7 +7,7 @@ import { useDispatch } from '@wordpress/data';
import { Button, Modal } from '@wordpress/components'; import { Button, Modal } from '@wordpress/components';
import { __ } from '@wordpress/i18n'; import { __ } from '@wordpress/i18n';
const DissmissAllModal = ( { onClose } ) => { const DismissAllModal = ( { onClose } ) => {
const { createNotice } = useDispatch( 'core/notices' ); const { createNotice } = useDispatch( 'core/notices' );
const { batchUpdateNotes, removeAllNotes } = useDispatch( const { batchUpdateNotes, removeAllNotes } = useDispatch(
@ -81,4 +81,4 @@ const DissmissAllModal = ( { onClose } ) => {
); );
}; };
export default DissmissAllModal; export default DismissAllModal;

2
plugins/woocommerce-admin/client/inbox-panel/index.js
View File

@ -26,7 +26,7 @@ import moment from 'moment';
import { ActivityCard } from '~/activity-panel/activity-card'; import { ActivityCard } from '~/activity-panel/activity-card';
import { hasValidNotes, truncateRenderableHTML } from './utils'; import { hasValidNotes, truncateRenderableHTML } from './utils';
import { getScreenName } from '../utils'; import { getScreenName } from '../utils';
import DismissAllModal from './dissmiss-all-modal'; import DismissAllModal from './dismiss-all-modal';
import './index.scss'; import './index.scss';
const renderEmptyCard = () => ( const renderEmptyCard = () => (

2
plugins/woocommerce-admin/client/profile-wizard/index.js
View File

@ -76,7 +76,6 @@ class ProfileWizard extends Component {
componentDidMount() { componentDidMount() {
document.body.classList.remove( 'woocommerce-admin-is-loading' ); document.body.classList.remove( 'woocommerce-admin-is-loading' );
document.body.classList.add( 'woocommerce-onboarding' );
document.body.classList.add( 'woocommerce-profile-wizard__body' ); document.body.classList.add( 'woocommerce-profile-wizard__body' );
document.body.classList.add( 'woocommerce-admin-full-screen' ); document.body.classList.add( 'woocommerce-admin-full-screen' );
document.body.classList.add( 'is-wp-toolbar-disabled' ); document.body.classList.add( 'is-wp-toolbar-disabled' );
@ -87,7 +86,6 @@ class ProfileWizard extends Component {
} }
componentWillUnmount() { componentWillUnmount() {
document.body.classList.remove( 'woocommerce-onboarding' );
document.body.classList.remove( 'woocommerce-profile-wizard__body' ); document.body.classList.remove( 'woocommerce-profile-wizard__body' );
document.body.classList.remove( 'woocommerce-admin-full-screen' ); document.body.classList.remove( 'woocommerce-admin-full-screen' );
document.body.classList.remove( 'is-wp-toolbar-disabled' ); document.body.classList.remove( 'is-wp-toolbar-disabled' );

4
plugins/woocommerce-admin/client/two-column-tasks/dissmiss-modal.js → plugins/woocommerce-admin/client/two-column-tasks/dismiss-modal.js
View File

@ -4,7 +4,7 @@
import { Button, Modal } from '@wordpress/components'; import { Button, Modal } from '@wordpress/components';
import { __ } from '@wordpress/i18n'; import { __ } from '@wordpress/i18n';
const DissmissModal = ( { const DismissModal = ( {
showDismissModal, showDismissModal,
setShowDismissModal, setShowDismissModal,
hideTasks, hideTasks,
@ -55,4 +55,4 @@ const DissmissModal = ( {
); );
}; };
export default DissmissModal; export default DismissModal;

6
plugins/woocommerce-admin/client/two-column-tasks/index.js
View File

@ -2,7 +2,6 @@
* External dependencies * External dependencies
*/ */
import { __ } from '@wordpress/i18n'; import { __ } from '@wordpress/i18n';
import { useEffect } from '@wordpress/element';
import { useSelect } from '@wordpress/data'; import { useSelect } from '@wordpress/data';
import { ONBOARDING_STORE_NAME, OPTIONS_STORE_NAME } from '@woocommerce/data'; import { ONBOARDING_STORE_NAME, OPTIONS_STORE_NAME } from '@woocommerce/data';
@ -35,11 +34,6 @@ const TaskDashboard = ( { query, twoColumns } ) => {
isResolving: isResolvingOptions, isResolving: isResolvingOptions,
} = useSelect( taskDashboardSelect ); } = useSelect( taskDashboardSelect );
useEffect( () => {
document.body.classList.add( 'woocommerce-onboarding' );
document.body.classList.add( 'woocommerce-task-dashboard__body' );
}, [] );
const { task } = query; const { task } = query;
const { isResolving, taskLists } = useSelect( ( select ) => { const { isResolving, taskLists } = useSelect( ( select ) => {

4
plugins/woocommerce-admin/client/two-column-tasks/style.scss
View File

@ -74,7 +74,7 @@
} }
} }
.woocommerce-task-dashboard__body .woocommerce-task-dashboard__container .woocommerce-task-card.completed { .woocommerce-task-dashboard__container .woocommerce-task-card.completed {
display: block; display: block;
.components-card__header { .components-card__header {
display: block; display: block;
@ -273,7 +273,7 @@
} }
} }
.woocommerce-task-dashboard__body .woocommerce-task-dismiss-modal { .woocommerce-task-dismiss-modal {
width: 565px; width: 565px;
max-width: 100%; max-width: 100%;

2
plugins/woocommerce-admin/client/two-column-tasks/task-list.js
View File

@ -17,7 +17,7 @@ import classnames from 'classnames';
*/ */
import '../tasks/task-list.scss'; import '../tasks/task-list.scss';
import taskHeaders from './task-headers'; import taskHeaders from './task-headers';
import DismissModal from './dissmiss-modal'; import DismissModal from './dismiss-modal';
import TaskListCompleted from './completed'; import TaskListCompleted from './completed';
export const TaskList = ( { export const TaskList = ( {