From 53be5776f473ec1b8e530e701b4198e0ccc748d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomek=20Wytr=C4=99bowicz?= <tomalecpub@gmail.com>
Date: Sun, 25 Aug 2024 19:56:59 +0200
Subject: [PATCH] Remove the usage of `<ReportSummary isRequesting>` as it has
 no effect (#50751)

The support for such property was removed in woocommerce/woocommerce-admin#4858 ~4 years ago.

Co-authored-by: github-actions <github-actions@github.com>
---
 .../client/analytics/components/report-summary/test/index.js  | 2 +-
 .../client/analytics/report/categories/index.js               | 1 -
 .../client/analytics/report/coupons/index.js                  | 1 -
 .../client/analytics/report/products/index.js                 | 1 -
 .../woocommerce-admin/client/analytics/report/taxes/index.js  | 1 -
 .../client/analytics/report/variations/index.js               | 1 -
 .../changelog/50751-fix-isRequesting-report-summary           | 4 ++++
 7 files changed, 5 insertions(+), 6 deletions(-)
 create mode 100644 plugins/woocommerce/changelog/50751-fix-isRequesting-report-summary

diff --git a/plugins/woocommerce-admin/client/analytics/components/report-summary/test/index.js b/plugins/woocommerce-admin/client/analytics/components/report-summary/test/index.js
index 970dee29eec..697071d8b69 100644
--- a/plugins/woocommerce-admin/client/analytics/components/report-summary/test/index.js
+++ b/plugins/woocommerce-admin/client/analytics/components/report-summary/test/index.js
@@ -134,7 +134,7 @@ describe( 'ReportSummary', () => {
 		).toBeInTheDocument();
 	} );
 
-	test( 'should display SummaryListPlaceholder when isRequesting is true', () => {
+	test( 'should display SummaryListPlaceholder when summaryData.isRequesting is true', () => {
 		const { container } = renderChart( 'number', null, null, false, true );
 
 		expect(
diff --git a/plugins/woocommerce-admin/client/analytics/report/categories/index.js b/plugins/woocommerce-admin/client/analytics/report/categories/index.js
index 904f1e1bac1..02110c765da 100644
--- a/plugins/woocommerce-admin/client/analytics/report/categories/index.js
+++ b/plugins/woocommerce-admin/client/analytics/report/categories/index.js
@@ -69,7 +69,6 @@ class CategoriesReport extends Component {
 				<ReportSummary
 					charts={ charts }
 					endpoint="products"
-					isRequesting={ isRequesting }
 					limitProperties={
 						isSingleCategoryView
 							? [ 'products', 'categories' ]
diff --git a/plugins/woocommerce-admin/client/analytics/report/coupons/index.js b/plugins/woocommerce-admin/client/analytics/report/coupons/index.js
index c682db5cf4d..e2bf92ec3d6 100644
--- a/plugins/woocommerce-admin/client/analytics/report/coupons/index.js
+++ b/plugins/woocommerce-admin/client/analytics/report/coupons/index.js
@@ -57,7 +57,6 @@ class CouponsReport extends Component {
 				<ReportSummary
 					charts={ charts }
 					endpoint="coupons"
-					isRequesting={ isRequesting }
 					query={ chartQuery }
 					selectedChart={ getSelectedChart( query.chart, charts ) }
 					filters={ filters }
diff --git a/plugins/woocommerce-admin/client/analytics/report/products/index.js b/plugins/woocommerce-admin/client/analytics/report/products/index.js
index 9307d67e207..bab9201f385 100644
--- a/plugins/woocommerce-admin/client/analytics/report/products/index.js
+++ b/plugins/woocommerce-admin/client/analytics/report/products/index.js
@@ -82,7 +82,6 @@ class ProductsReport extends Component {
 					mode={ mode }
 					charts={ charts }
 					endpoint="products"
-					isRequesting={ isRequesting }
 					query={ chartQuery }
 					selectedChart={ getSelectedChart( query.chart, charts ) }
 					filters={ filters }
diff --git a/plugins/woocommerce-admin/client/analytics/report/taxes/index.js b/plugins/woocommerce-admin/client/analytics/report/taxes/index.js
index 1b089e790c0..493ca5e30b8 100644
--- a/plugins/woocommerce-admin/client/analytics/report/taxes/index.js
+++ b/plugins/woocommerce-admin/client/analytics/report/taxes/index.js
@@ -52,7 +52,6 @@ class TaxesReport extends Component {
 				<ReportSummary
 					charts={ charts }
 					endpoint="taxes"
-					isRequesting={ isRequesting }
 					query={ chartQuery }
 					selectedChart={ getSelectedChart( query.chart, charts ) }
 					filters={ filters }
diff --git a/plugins/woocommerce-admin/client/analytics/report/variations/index.js b/plugins/woocommerce-admin/client/analytics/report/variations/index.js
index 17eb554577d..245094a9738 100644
--- a/plugins/woocommerce-admin/client/analytics/report/variations/index.js
+++ b/plugins/woocommerce-admin/client/analytics/report/variations/index.js
@@ -59,7 +59,6 @@ const VariationsReport = ( props ) => {
 				mode={ mode }
 				charts={ charts }
 				endpoint="variations"
-				isRequesting={ isRequesting }
 				query={ chartQuery }
 				selectedChart={ getSelectedChart( query.chart, charts ) }
 				filters={ filters }
diff --git a/plugins/woocommerce/changelog/50751-fix-isRequesting-report-summary b/plugins/woocommerce/changelog/50751-fix-isRequesting-report-summary
new file mode 100644
index 00000000000..052457d7f62
--- /dev/null
+++ b/plugins/woocommerce/changelog/50751-fix-isRequesting-report-summary
@@ -0,0 +1,4 @@
+Significance: patch
+Type: tweak
+
+Remove the usage of `ReportSummary`s `isRequesting` property as it has no effect.
\ No newline at end of file