Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make 'Rows Per Table' <select> accessible (https://github.com/woocommerce/woocommerce-admin/pull/1674)

This commit is contained in:
Albert Juhé Lluveras 2019-02-25 11:17:56 +01:00 committed by GitHub
parent a3e4955f74
commit 55336a9874
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/woocommerce-admin/client/dashboard/leaderboards/index.js
View File

@ -95,7 +95,9 @@ class Leaderboards extends Component {
},
];
return (
<EllipsisMenu label={ __( 'Choose which leaderboards to display', 'wc-admin' ) }>
<EllipsisMenu
label={ __( 'Choose which leaderboards to display and the number of rows', 'wc-admin' ) }
>
<Fragment>
<MenuTitle>{ __( 'Leaderboards', 'wc-admin' ) }</MenuTitle>
{ allLeaderboards.map( leaderboard => {
@ -109,9 +111,9 @@ class Leaderboards extends Component {
</MenuItem>
);
} ) }
<MenuTitle>{ __( 'Rows Per Table', 'wc-admin' ) }</MenuTitle>
<SelectControl
className="woocommerce-ellipsis-menu__item"
className="woocommerce-dashboard__dashboard-leaderboards__select"
label={ <MenuTitle>{ __( 'Rows Per Table', 'wc-admin' ) }</MenuTitle> }
value={ rowsPerTable }
options={ Array.from( { length: 20 }, ( v, key ) => ( {
v: key + 1,

8
plugins/woocommerce-admin/client/dashboard/leaderboards/style.scss
View File

@ -8,4 +8,12 @@
border: 1px solid $core-grey-light-700;
height: 34px;
}
.woocommerce-dashboard__dashboard-leaderboards__select {
.components-base-control__field {
padding: 0 12px 4px;
}
.woocommerce-ellipsis-menu__title {
padding: 10px 0 14px;
}
}
}