Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rephrase the test so that is more resilient and error-prone

This commit is contained in:
vedanshujain 2020-05-11 14:31:58 +05:30
parent 02aa89614e
commit 569e656459
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
unit-tests/Tests/Version3/functions.php
View File

@ -82,15 +82,11 @@ class WC_Tests_API_Functions extends WC_Unit_Test_Case {
*/ */
public function test_wc_rest_upload_image_from_url_should_return_error_when_invalid_image_is_passed() { public function test_wc_rest_upload_image_from_url_should_return_error_when_invalid_image_is_passed() {
// empty file. // empty file.
if ( version_compare( get_bloginfo( 'version' ), '5.4-alpha', '>=' ) ) { $expected_error_message = 'Invalid image: File is empty.';
$expected_error_message = 'Invalid image: File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini file or by post_max_size being defined as smaller than upload_max_filesize in php.ini.';
} else {
$expected_error_message = 'Invalid image: File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini or by post_max_size being defined as smaller than upload_max_filesize in php.ini.';
}
$result = wc_rest_upload_image_from_url( 'http://somedomain.com/invalid-image-1.png' ); $result = wc_rest_upload_image_from_url( 'http://somedomain.com/invalid-image-1.png' );
$this->assertWPError( $result ); $this->assertWPError( $result );
$this->assertEquals( $expected_error_message, $result->get_error_message() ); $this->assertStringStartsWith( $expected_error_message, $result->get_error_message() );
// unsupported mime type. // unsupported mime type.
$expected_error_message = 'Invalid image: Sorry, this file type is not permitted for security reasons.'; $expected_error_message = 'Invalid image: Sorry, this file type is not permitted for security reasons.';