Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make unit tests work again with PHP 5.2 

This commit fixes WC PHPUnit tests in PHP 5.2 that have been broken since commit e68084d7b8 (diff-b43983ff635e47e2ec510ae07726f0b4R30) was merged. The mentioned commit added a new method to WC_Unit_Test_Case that uses late static binding. The problem is that late static binding is available only since PHP 5.3 and WooCommerce still support PHP 5.2. Running WC tests with PHP 5.2 resulted in the following error:

Parse error: syntax error, unexpected T_STATIC, expecting T_STRING or T_VARIABLE or '$' in /home/travis/build/woocommerce/woocommerce/tests/framework/class-wc-unit-test-case.php on line 40 (see https://travis-ci.org/woocommerce/woocommerce/jobs/350303315#L281)

For now, I'm simply removing the method that used late static binding (WC_Unit_Test_Case::include_dependencies()) and manually loading the required dependencies in the two test classes that relied on it. I'm happy to add WC_Unit_Test_Case::include_dependencies() again if someone can find a way to make it compatible with PHP 5.2. If not, we can revisit this once WC drops support for PHP 5.2.
This commit is contained in:
Rodrigo Primo 2018-03-12 15:20:58 -03:00
parent 4fbd01f003
commit 5a5a2bc1fb
3 changed files with 9 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/framework/class-wc-unit-test-case.php
View File

@ -22,28 +22,6 @@ class WC_Unit_Test_Case extends WP_UnitTestCase {
*/ */
protected $factory; protected $factory;
/**
* Additional files, relative to the plugin's root directory, that should be explicitly included.
*
* @var array
*/
protected static $includes;
/**
* If a test has declared include files, load them before running the tests in the class.
*
* @beforeClass
*/
public static function include_dependencies() {
$base_dir = trailingslashit( dirname( dirname( __DIR__ ) ) );
if ( ! empty( static::$includes ) ) {
foreach ( (array) static::$includes as $include ) {
include_once $base_dir . $include;
}
}
}
/** /**
* Setup test case. * Setup test case.
* *

9
tests/unit-tests/admin/reports/class-wc-tests-admin-report.php
View File

@ -11,13 +11,12 @@
class WC_Tests_Admin_Report extends WC_Unit_Test_Case { class WC_Tests_Admin_Report extends WC_Unit_Test_Case {
/** /**
* Additional files, relative to the plugin's root directory, that should be explicitly included. * Load the necessary files, as they're not automatically loaded by WooCommerce.
* *
* @var array
*/ */
public static $includes = array( public static function setUpBeforeClass() {
'includes/admin/reports/class-wc-admin-report.php', include_once WC_Unit_Tests_Bootstrap::instance()->plugin_dir . '/includes/admin/reports/class-wc-admin-report.php';
); }
/** /**
* Clear cached report data. * Clear cached report data.

12
tests/unit-tests/admin/reports/class-wc-tests-report-sales-by-date.php
View File

@ -11,14 +11,12 @@
class WC_Tests_Report_Sales_By_Date extends WC_Unit_Test_Case { class WC_Tests_Report_Sales_By_Date extends WC_Unit_Test_Case {
/** /**
* Additional files, relative to the plugin's root directory, that should be explicitly included. * Load the necessary files, as they're not automatically loaded by WooCommerce.
*
* @var array
*/ */
protected static $includes = array( public static function setUpBeforeClass() {
'includes/admin/reports/class-wc-admin-report.php', include_once WC_Unit_Tests_Bootstrap::instance()->plugin_dir . '/includes/admin/reports/class-wc-admin-report.php';
'includes/admin/reports/class-wc-report-sales-by-date.php', include_once WC_Unit_Tests_Bootstrap::instance()->plugin_dir . '/includes/admin/reports/class-wc-report-sales-by-date.php';
); }
/** /**
* Clear cached report data. * Clear cached report data.