From 5c1e20c7d10b1ae1442a663d4fc1faaafbba9e9a Mon Sep 17 00:00:00 2001 From: haszari Date: Thu, 21 Feb 2019 11:48:18 +1300 Subject: [PATCH] store dismissed suggestions in user meta, don't manually json-encode --- .../class-wc-marketplace-suggestions-api.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/includes/marketplace-suggestions/class-wc-marketplace-suggestions-api.php b/includes/marketplace-suggestions/class-wc-marketplace-suggestions-api.php index 32ec100e298..eb670d1906b 100644 --- a/includes/marketplace-suggestions/class-wc-marketplace-suggestions-api.php +++ b/includes/marketplace-suggestions/class-wc-marketplace-suggestions-api.php @@ -56,9 +56,9 @@ function wc_marketplace_suggestions_ajax_handler() { function wc_marketplace_suggestions_get_dismissed() { $dismissed_suggestions = array(); - $dismissed_suggestions_data = get_user_option( 'wc_marketplace_suggestions_dismissed_suggestions', get_current_user_id() ); + $dismissed_suggestions_data = get_user_meta( 'wc_marketplace_suggestions_dismissed_suggestions', get_current_user_id() ); if ( $dismissed_suggestions_data ) { - $dismissed_suggestions = json_decode( $dismissed_suggestions_data ); + $dismissed_suggestions = $dismissed_suggestions_data; if ( ! is_array( $dismissed_suggestions ) ) { $dismissed_suggestions = array(); } @@ -88,12 +88,10 @@ function wc_marketplace_suggestions_dismiss_handler() { } $dismissed_suggestions[] = $suggestion_slug; - - // Could also store these in transient, with a long expiry (e.g. 6 months). - update_user_option( + update_user_meta( get_current_user_id(), 'wc_marketplace_suggestions_dismissed_suggestions', - wp_json_encode( $dismissed_suggestions ) + $dismissed_suggestions ); wp_die();