Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Further get_variation_prices tweaks 

For 2.5, I’ve adjusted the caching to store 1 transient per variable
product. The cache key etc is still needed, but its stored within a
single transient instead of several.

This should prevent exponential growth of transient data for users.

Thoughts?

@daigo75 @franticpsyx @claudiosmweb
This commit is contained in:
Mike Jolley 2015-10-09 12:49:39 +01:00
parent 68cb6b11ee
commit 6027b355ca
1 changed files with 36 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
includes/class-wc-product-variable.php
View File

@ -24,7 +24,7 @@ class WC_Product_Variable extends WC_Product {
public $total_stock; public $total_stock;
/** @private array Array of variation prices. */ /** @private array Array of variation prices. */
private $prices_array; private $prices_array = array();
/** /**
* Constructor * Constructor
@ -265,30 +265,45 @@ class WC_Product_Variable extends WC_Product {
global $wp_filter; global $wp_filter;
/** /**
* Create unique cache key based on the tax location (affects displayed/cached prices), product version and active price filters. * Transient name for storing prices for this product.
* Max transient length is 45, -10 for get_transient_version. * Max transient length is 45, -10 for get_transient_version.
* @var string * @var string
* @since 2.5.0 a single transient is used per product for all prices, rather than many transients per product.
*/ */
$hash = array( $this->id, $display, $display ? WC_Tax::get_rates() : array() ); $transient_name = 'wc_var_prices' . $this->id . '_' . WC_Cache_Helper::get_transient_version( 'product' );
/**
* Create unique cache key based on the tax location (affects displayed/cached prices), product version and active price filters.
* DEVELOPERS should filter this hash if offering conditonal pricing to keep it unique.
* @var string
*/
if ( $display ) {
$price_hash = array( true, WC_Tax::get_rates(), get_option( 'woocommerce_tax_display_shop' ) );
} else {
$price_hash = array( false );
}
foreach ( $wp_filter as $key => $val ) { foreach ( $wp_filter as $key => $val ) {
if ( in_array( $key, array( 'woocommerce_variation_prices_price', 'woocommerce_variation_prices_regular_price', 'woocommerce_variation_prices_sale_price' ) ) ) { if ( in_array( $key, array( 'woocommerce_variation_prices_price', 'woocommerce_variation_prices_regular_price', 'woocommerce_variation_prices_sale_price' ) ) ) {
$hash[ $key ] = $val; $price_hash[ $key ] = $val;
} }
} }
/** $price_hash = md5( json_encode( apply_filters( 'woocommerce_get_variation_prices_hash', $price_hash, $this, $display ) ) );
* DEVELOPERS should filter this hash if offering conditonal pricing to keep it unique.
*/
$hash = apply_filters( 'woocommerce_get_variation_prices_hash', $hash, $this, $display );
$cache_key = 'wc_var_prices' . substr( md5( json_encode( $hash ) ), 0, 22 ) . WC_Cache_Helper::get_transient_version( 'product' );
$this->prices_array = get_transient( $cache_key );
if ( empty( $this->prices_array ) ) { // If the value has already been generated, return it now
if ( ! empty( $this->prices_array[ $price_hash ] ) ) {
return $this->prices_array[ $price_hash ];
}
// Get value of transient
$this->prices_array = array_filter( (array) get_transient( $transient_name ) );
// If the prices are not stored for this hash, generate them
if ( empty( $this->prices_array[ $price_hash ] ) ) {
$prices = array(); $prices = array();
$regular_prices = array(); $regular_prices = array();
$sale_prices = array(); $sale_prices = array();
$tax_display_mode = get_option( 'woocommerce_tax_display_shop' );
$variation_ids = $this->get_children( true ); $variation_ids = $this->get_children( true );
foreach ( $variation_ids as $variation_id ) { foreach ( $variation_ids as $variation_id ) {
@ -304,7 +319,7 @@ class WC_Product_Variable extends WC_Product {
// If we are getting prices for display, we need to account for taxes // If we are getting prices for display, we need to account for taxes
if ( $display ) { if ( $display ) {
if ( 'incl' === $tax_display_mode ) { if ( 'incl' === get_option( 'woocommerce_tax_display_shop' ) ) {
$price = '' === $price ? '' : $variation->get_price_including_tax( 1, $price ); $price = '' === $price ? '' : $variation->get_price_including_tax( 1, $price );
$regular_price = '' === $regular_price ? '' : $variation->get_price_including_tax( 1, $regular_price ); $regular_price = '' === $regular_price ? '' : $variation->get_price_including_tax( 1, $regular_price );
$sale_price = '' === $sale_price ? '' : $variation->get_price_including_tax( 1, $sale_price ); $sale_price = '' === $sale_price ? '' : $variation->get_price_including_tax( 1, $sale_price );
@ -325,19 +340,19 @@ class WC_Product_Variable extends WC_Product {
asort( $regular_prices ); asort( $regular_prices );
asort( $sale_prices ); asort( $sale_prices );
$this->prices_array = array( $this->prices_array[ $price_hash ] = array(
'price' => $prices, 'price' => $prices,
'regular_price' => $regular_prices, 'regular_price' => $regular_prices,
'sale_price' => $sale_prices 'sale_price' => $sale_prices
); );
set_transient( $cache_key, $this->prices_array, DAY_IN_SECONDS * 30 ); set_transient( $transient_name, $this->prices_array, DAY_IN_SECONDS * 30 );
} }
/** /**
* Give plugins one last chance to filter the variation prices array. * Give plugins one last chance to filter the variation prices array which is being returned.
*/ */
return $this->prices_array = apply_filters( 'woocommerce_variation_prices', $this->prices_array, $this, $display ); return $this->prices_array[ $price_hash ] = apply_filters( 'woocommerce_variation_prices', $this->prices_array[ $price_hash ], $this, $display );
} }
/** /**