From 65d9c6764cbc34da42867c0e61efe976627998e9 Mon Sep 17 00:00:00 2001 From: Alexandre Lara Date: Mon, 8 Jan 2024 16:58:27 -0300 Subject: [PATCH] [Experimental] Product Gallery block: Rename media setting to "Open pop-up when clicked" (#43302) * Rename media setting to "Open pop-up when clicked" * Add changefile(s) from automation for the following project(s): woocommerce-blocks --------- Co-authored-by: github-actions --- .../assets/js/blocks/product-gallery/block-settings/index.tsx | 2 +- .../product-gallery.block_theme.side_effects.spec.ts | 2 +- .../tests/e2e/tests/product-gallery/product-gallery.page.ts | 2 +- ...factor-43295-rename-media-setting-full-screen-when-clicked | 4 ++++ 4 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 plugins/woocommerce/changelog/43302-refactor-43295-rename-media-setting-full-screen-when-clicked diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-gallery/block-settings/index.tsx b/plugins/woocommerce-blocks/assets/js/blocks/product-gallery/block-settings/index.tsx index 5f2aafc47c8..6cd8c76b371 100644 --- a/plugins/woocommerce-blocks/assets/js/blocks/product-gallery/block-settings/index.tsx +++ b/plugins/woocommerce-blocks/assets/js/blocks/product-gallery/block-settings/index.tsx @@ -75,7 +75,7 @@ export const ProductGalleryBlockSettings = ( { } /> { } ); } ); - test.describe( 'full-screen when clicked option', () => { + test.describe( 'open pop-up when clicked option', () => { test( 'should be enabled by default', async ( { pageObject, editor, diff --git a/plugins/woocommerce-blocks/tests/e2e/tests/product-gallery/product-gallery.page.ts b/plugins/woocommerce-blocks/tests/e2e/tests/product-gallery/product-gallery.page.ts index d59a51088fa..f2dbe29f2ff 100644 --- a/plugins/woocommerce-blocks/tests/e2e/tests/product-gallery/product-gallery.page.ts +++ b/plugins/woocommerce-blocks/tests/e2e/tests/product-gallery/product-gallery.page.ts @@ -10,7 +10,7 @@ const selectors = { zoomWhileHoveringSetting: "xpath=//label[contains(text(), 'Zoom while hovering')]/preceding-sibling::span/input", fullScreenOnClickSetting: - "xpath=//label[contains(text(), 'Full-screen when clicked')]/preceding-sibling::span/input", + "xpath=//label[contains(text(), 'Open pop-up when clicked')]/preceding-sibling::span/input", }, }; diff --git a/plugins/woocommerce/changelog/43302-refactor-43295-rename-media-setting-full-screen-when-clicked b/plugins/woocommerce/changelog/43302-refactor-43295-rename-media-setting-full-screen-when-clicked new file mode 100644 index 00000000000..946ee68eb83 --- /dev/null +++ b/plugins/woocommerce/changelog/43302-refactor-43295-rename-media-setting-full-screen-when-clicked @@ -0,0 +1,4 @@ +Significance: patch +Type: dev +Comment: Rename the media setting from "Full-screen when clicked" to "Open pop-up when clicked" +