From 664694e165cfa3f34fe65a59e43ac1cebcb8090b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ismael=20Mart=C3=ADn=20Alabarce?= Date: Thu, 15 Apr 2021 08:49:35 +0200 Subject: [PATCH] Render optional children in summary number component (https://github.com/woocommerce/woocommerce-admin/pull/6748) * WIP add details prop to summary number component. New optional prop to add additional information at the bottom. * Update component readme and stories to include new prop * Revert commits to use children instead of a new prop * Render optional summary number component children * Typo fix, doc improvement and add entry to changelog * Add readme.txt entry --- plugins/woocommerce-admin/packages/components/CHANGELOG.md | 4 ++++ .../packages/components/src/summary/README.md | 6 ++++-- .../packages/components/src/summary/number.js | 5 ++++- .../packages/components/src/summary/stories/index.js | 4 +++- plugins/woocommerce-admin/readme.txt | 1 + 5 files changed, 16 insertions(+), 4 deletions(-) diff --git a/plugins/woocommerce-admin/packages/components/CHANGELOG.md b/plugins/woocommerce-admin/packages/components/CHANGELOG.md index 44187f7b38a..967bad67a15 100644 --- a/plugins/woocommerce-admin/packages/components/CHANGELOG.md +++ b/plugins/woocommerce-admin/packages/components/CHANGELOG.md @@ -1,3 +1,7 @@ +# Unreleased + +- Add optional `children` prop to ``. + # 6.0.0 - Change styling of ``. diff --git a/plugins/woocommerce-admin/packages/components/src/summary/README.md b/plugins/woocommerce-admin/packages/components/src/summary/README.md index 3fd296d005f..20ba6c2203b 100644 --- a/plugins/woocommerce-admin/packages/components/src/summary/README.md +++ b/plugins/woocommerce-admin/packages/components/src/summary/README.md @@ -15,7 +15,9 @@ A container element for a list of SummaryNumbers. This component handles detecti label="Total Sales" delta={ 29 } href="/analytics/report" - />, + > + 27 orders + , ) : null } + { children } ); diff --git a/plugins/woocommerce-admin/packages/components/src/summary/stories/index.js b/plugins/woocommerce-admin/packages/components/src/summary/stories/index.js index f60e0b2356d..0868a243cc2 100644 --- a/plugins/woocommerce-admin/packages/components/src/summary/stories/index.js +++ b/plugins/woocommerce-admin/packages/components/src/summary/stories/index.js @@ -13,7 +13,9 @@ export const Basic = () => ( label="Total Sales" delta={ 29 } href="/analytics/report" - />, + > + 27 orders + ,