From 6747e90cebbaf79bf3fa53de657cbf6ac681abb0 Mon Sep 17 00:00:00 2001 From: Moon Date: Tue, 2 Nov 2021 21:17:26 -0700 Subject: [PATCH] Remove the Spinner component while loading the store alerts (https://github.com/woocommerce/woocommerce-admin/pull/7886) * Remove Spinner * Add changelog * Use null so it render nothing * Update changelog --- .../changelogs/update-7336-remove-loading-indicator | 4 ++++ plugins/woocommerce-admin/client/layout/index.js | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 plugins/woocommerce-admin/changelogs/update-7336-remove-loading-indicator diff --git a/plugins/woocommerce-admin/changelogs/update-7336-remove-loading-indicator b/plugins/woocommerce-admin/changelogs/update-7336-remove-loading-indicator new file mode 100644 index 00000000000..f1adf732acf --- /dev/null +++ b/plugins/woocommerce-admin/changelogs/update-7336-remove-loading-indicator @@ -0,0 +1,4 @@ +Significance: minor +Type: Tweak + +Remove the Spinner component to prevent undesired page flickering. #7886 diff --git a/plugins/woocommerce-admin/client/layout/index.js b/plugins/woocommerce-admin/client/layout/index.js index 9d4bf02f77b..2389ad18aed 100644 --- a/plugins/woocommerce-admin/client/layout/index.js +++ b/plugins/woocommerce-admin/client/layout/index.js @@ -9,7 +9,6 @@ import { Router, Route, Switch } from 'react-router-dom'; import PropTypes from 'prop-types'; import { get, isFunction, identity } from 'lodash'; import { parse } from 'qs'; -import { Spinner } from '@woocommerce/components'; import { getHistory, getQuery } from '@woocommerce/navigation'; import { getSetting } from '@woocommerce/wc-admin-settings'; import { @@ -51,7 +50,7 @@ export class PrimaryLayout extends Component { id="woocommerce-layout__primary" > { window.wcAdminFeatures[ 'store-alerts' ] && ( - }> + ) }