From 67f2f750c4de7f335292d8a32a4ba32dc9067162 Mon Sep 17 00:00:00 2001
From: Tung Du <dinhtungdu@gmail.com>
Date: Wed, 18 Sep 2024 21:35:43 +0700
Subject: [PATCH] fix: remove navigate import from the product-filters store

---
 .../js/blocks/product-filters/frontend.ts     | 67 +++++++++----------
 1 file changed, 33 insertions(+), 34 deletions(-)

diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-filters/frontend.ts b/plugins/woocommerce-blocks/assets/js/blocks/product-filters/frontend.ts
index 380a3e79ebc..f0707c07bb7 100644
--- a/plugins/woocommerce-blocks/assets/js/blocks/product-filters/frontend.ts
+++ b/plugins/woocommerce-blocks/assets/js/blocks/product-filters/frontend.ts
@@ -1,11 +1,7 @@
 /**
  * External dependencies
  */
-import {
-	getContext,
-	store,
-	navigate as navigateFn,
-} from '@woocommerce/interactivity';
+import { getContext, store } from '@woocommerce/interactivity';
 import { getSetting } from '@woocommerce/settings';
 
 const isBlockTheme = getSetting< boolean >( 'isBlockTheme' );
@@ -38,33 +34,7 @@ function isParamsEqual(
 }
 
 export function navigate( href: string, options = {} ) {
-	/**
-	 * We may need to reset the current page when changing filters.
-	 * This is because the current page may not exist for this set
-	 * of filters and will 404 when the user navigates to it.
-	 *
-	 * There are different pagination formats to consider, as documented here:
-	 * https://github.com/WordPress/gutenberg/blob/317eb8f14c8e1b81bf56972cca2694be250580e3/packages/block-library/src/query-pagination-numbers/index.php#L22-L85
-	 */
-	const url = new URL( href );
-	// When pretty permalinks are enabled, the page number may be in the path name.
-	url.pathname = url.pathname.replace( /\/page\/[0-9]+/i, '' );
-	// When plain permalinks are enabled, the page number may be in the "paged" query parameter.
-	url.searchParams.delete( 'paged' );
-	// On posts and pages the page number will be in a query parameter that
-	// identifies which block we are paginating.
-	url.searchParams.forEach( ( _, key ) => {
-		if ( key.match( /^query(?:-[0-9]+)?-page$/ ) ) {
-			url.searchParams.delete( key );
-		}
-	} );
-	// Make sure to update the href with the changes.
-	href = url.href;
-
-	if ( needsRefresh || ( ! isBlockTheme && isProductArchive ) ) {
-		return ( window.location.href = href );
-	}
-	return navigateFn( href, options );
+	return '';
 }
 
 export interface ProductFiltersContext {
@@ -99,9 +69,10 @@ store( 'woocommerce/product-filters', {
 		},
 	},
 	callbacks: {
-		maybeNavigate: () => {
+		*maybeNavigate() {
 			const { params, originalParams } =
 				getContext< ProductFiltersContext >();
+			console.log( params, originalParams );
 
 			if ( isParamsEqual( params, originalParams ) ) {
 				return;
@@ -117,7 +88,35 @@ store( 'woocommerce/product-filters', {
 			for ( const key in params ) {
 				searchParams.set( key, params[ key ] );
 			}
-			navigate( url.href );
+
+			/**
+			 * We may need to reset the current page when changing filters.
+			 * This is because the current page may not exist for this set
+			 * of filters and will 404 when the user navigates to it.
+			 *
+			 * There are different pagination formats to consider, as documented here:
+			 * https://github.com/WordPress/gutenberg/blob/317eb8f14c8e1b81bf56972cca2694be250580e3/packages/block-library/src/query-pagination-numbers/index.php#L22-L85
+			 */
+			// When pretty permalinks are enabled, the page number may be in the path name.
+			url.pathname = url.pathname.replace( /\/page\/[0-9]+/i, '' );
+			// When plain permalinks are enabled, the page number may be in the "paged" query parameter.
+			url.searchParams.delete( 'paged' );
+			// On posts and pages the page number will be in a query parameter that
+			// identifies which block we are paginating.
+			url.searchParams.forEach( ( _, key ) => {
+				if ( key.match( /^query(?:-[0-9]+)?-page$/ ) ) {
+					url.searchParams.delete( key );
+				}
+			} );
+
+			if ( needsRefresh || ( ! isBlockTheme && isProductArchive ) ) {
+				return ( window.location.href = url.href );
+			}
+
+			const { actions } = yield import(
+				'@woocommerce/interactivity-router'
+			);
+			yield actions.navigate( url.href );
 		},
 	},
 } );