Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CI: update linting jobs to skip build step (#49193) 

In this PR, we introduce changes to linting and PHPUnit jobs in order to speed them up: skip or minimize the build step.
This commit is contained in:
Vladimir Reznichenko 2024-07-08 08:39:39 +02:00 committed by GitHub
parent 6d17019827
commit 68532ce433
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
21 changed files with 224 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
.github/actions/setup-woocommerce-monorepo/action.yml vendored
View File

@ -10,6 +10,9 @@ inputs:
build:
description: 'Given a boolean or PNPM filter, runs the build command for monorepo project(s).'
default: false
build-type:
description: 'Given "full" or "backend" will perform optimized build steps.'
default: 'full'
pull-playwright-cache:
description: 'Given a boolean value, invokes Playwright dependencies caching.'
default: false
@ -73,4 +76,10 @@ runs:
# Boolean inputs aren't parsed into filters so it'll either be "true" or there will be a filter.
if: ${{ inputs.build == 'true' || steps.project-filters.outputs.build != '' }}
shell: 'bash'
run: 'pnpm ${{ steps.project-filters.outputs.build }} build'
run: |
if [[ '${{ inputs.build-type }}' == 'backend' ]]; then
pnpm --filter="@woocommerce/admin-library" build:project:feature-config
fi
if [[ '${{ inputs.build-type }}' == 'full' ]]; then
pnpm ${{ steps.project-filters.outputs.build }} build
fi

14
.github/workflows/ci.yml vendored
View File

@ -94,7 +94,6 @@ jobs:
id: 'setup-monorepo'
with:
install: '${{ matrix.projectName }}...'
build: '${{ matrix.projectName }}'
- name: 'Lint'
run: 'pnpm --filter="${{ matrix.projectName }}" ${{ matrix.command }}'
@ -118,17 +117,10 @@ jobs:
id: 'install-monorepo'
with:
install: '${{ matrix.projectName }}...'
build: 'false'
build: ${{ ( github.ref_type == 'tag' && 'false' ) || matrix.projectName }}
build-type: ${{ ( matrix.testType == 'unit:php' && 'backend' ) || 'full' }}
pull-playwright-cache: ${{ matrix.testEnv.shouldCreate && matrix.testType == 'e2e' }}
- uses: './.github/actions/setup-woocommerce-monorepo'
if: ${{ github.ref_type != 'tag' }}
name: 'Build project'
id: 'build-project'
with:
install: 'false'
build: ${{ matrix.projectName }}
- name: 'Update wp-env config'
if: ${{ github.ref_type == 'tag' }}
env:
@ -159,7 +151,7 @@ jobs:
echo "COMMIT_MESSAGE=$COMMIT_MESSAGE" >> "$GITHUB_OUTPUT"
shell: bash
- name: 'Run tests'
- name: 'Run tests (${{ matrix.testType }})'
env:
E2E_ENV_KEY: ${{ secrets.E2E_ENV_KEY }}
BUILDKITE_ANALYTICS_TOKEN: ${{ secrets.BUILDKITE_CORE_E2E_TOKEN }}

7
packages/js/admin-e2e-tests/.eslintrc.js
View File

@ -4,4 +4,11 @@ module.exports = {
'plugin:@woocommerce/eslint-plugin/recommended',
],
root: true,
settings: {
'import/core-modules': [ '@woocommerce/e2e-utils' ],
'import/resolver': {
node: {},
typescript: {},
},
},
};

12
packages/js/admin-layout/.eslintrc.js Normal file
View File

@ -0,0 +1,12 @@
module.exports = {
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
root: true,
settings: {
'import/core-modules': [ '@woocommerce/components' ],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

12
packages/js/block-templates/.eslintrc.js
View File

@ -9,4 +9,16 @@ module.exports = {
},
},
],
settings: {
'import/core-modules': [
'@wordpress/core-data',
'@wordpress/blocks',
'@woocommerce/expression-evaluation',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

23
packages/js/components/.eslintrc.js
View File

@ -17,4 +17,27 @@ module.exports = {
},
},
],
settings: {
'import/core-modules': [
'@woocommerce/components',
'@woocommerce/currency',
'@woocommerce/data',
'@woocommerce/date',
'@woocommerce/navigation',
'@storybook/react',
'@automattic/tour-kit',
'@wordpress/blocks',
'@wordpress/components',
'@wordpress/element',
'@wordpress/media-utils',
'dompurify',
'downshift',
'moment',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

10
packages/js/currency/.eslintrc.js
View File

@ -1,4 +1,14 @@
module.exports = {
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
root: true,
settings: {
'import/core-modules': [
'@woocommerce/number',
'@woocommerce/settings',
],
'import/resolver': {
node: {},
typescript: {},
},
},
};

14
packages/js/customer-effort-score/.eslintrc.js
View File

@ -1,4 +1,18 @@
module.exports = {
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
root: true,
settings: {
'import/core-modules': [
'@woocommerce/data',
'@woocommerce/experimental',
'@woocommerce/navigation',
'@woocommerce/tracks',
'@testing-library/react',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

16
packages/js/data/.eslintrc.js
View File

@ -1,4 +1,20 @@
module.exports = {
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
root: true,
settings: {
'import/core-modules': [
'@woocommerce/date',
'@woocommerce/navigation',
'@woocommerce/tracks',
'@wordpress/api-fetch',
'@wordpress/core-data',
'@wordpress/data',
'@automattic/data-stores',
'redux',
],
'import/resolver': {
node: {},
typescript: {},
},
},
};

14
packages/js/experimental/.eslintrc.js
View File

@ -1,4 +1,18 @@
module.exports = {
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
root: true,
settings: {
'import/core-modules': [
'@woocommerce/components',
'@wordpress/components',
'@storybook/react',
'react-transition-group/CSSTransition',
'dompurify',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

12
packages/js/onboarding/.eslintrc.js
View File

@ -1,4 +1,16 @@
module.exports = {
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
root: true,
settings: {
'import/core-modules': [
'@woocommerce/experimental',
'@woocommerce/components',
'@woocommerce/tracks',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

32
packages/js/product-editor/.eslintrc.js
View File

@ -9,4 +9,36 @@ module.exports = {
},
},
],
settings: {
'import/core-modules': [
'@woocommerce/admin-layout',
'@woocommerce/block-templates',
'@woocommerce/components',
'@woocommerce/customer-effort-score',
'@woocommerce/currency',
'@woocommerce/data',
'@woocommerce/experimental',
'@woocommerce/expression-evaluation',
'@woocommerce/navigation',
'@woocommerce/number',
'@woocommerce/settings',
'@woocommerce/tracks',
'@wordpress/blocks',
'@wordpress/block-editor',
'@wordpress/components',
'@wordpress/core-data',
'@wordpress/date',
'@wordpress/element',
'@wordpress/keycodes',
'@wordpress/media-utils',
'@testing-library/react',
'dompurify',
'react-router-dom',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {},
},
},
};

34
plugins/woocommerce-admin/.eslintrc.js
View File

@ -11,7 +11,41 @@ module.exports = {
},
],
settings: {
'import/core-modules': [
'@woocommerce/ai',
'@woocommerce/admin-layout',
'@woocommerce/components',
'@woocommerce/customer-effort-score',
'@woocommerce/currency',
'@woocommerce/csv-export',
'@woocommerce/data',
'@woocommerce/date',
'@woocommerce/explat',
'@woocommerce/internal-js-tests',
'@woocommerce/navigation',
'@woocommerce/number',
'@woocommerce/onboarding',
'@woocommerce/product-editor',
'@woocommerce/settings',
'@woocommerce/tracks',
'@woocommerce/experimental',
'@wordpress/components',
'@wordpress/core-data',
'@wordpress/element',
'@wordpress/blocks',
'@wordpress/block-editor',
'@wordpress/block-library',
'@wordpress/notices',
'dompurify',
'@react-spring/web',
'react-router-dom',
'redux',
'xstate',
'xstate5',
],
'import/resolver': {
node: {},
webpack: {},
typescript: {
project: [ 'plugins/woocommerce-admin/tsconfig.json' ],
},

2
plugins/woocommerce-admin/package.json
View File

@ -17,7 +17,7 @@
"build:project": "pnpm --if-present '/^build:project:.*$/'",
"build:project:bundle": "wireit",
"build:project:feature-config": "php ../woocommerce/bin/generate-feature-config.php",
"changelog": "composer install && composer exec -- changelogger",
"changelog": "XDEBUG_MODE=off composer install --quiet && composer exec -- changelogger",
"example": "webpack --config docs/examples/extensions/examples.config.js",
"lint": "pnpm --if-present '/^lint:lang:.*$/'",
"lint:fix": "pnpm --if-present '/^lint:fix:lang:.*$/'",

1
plugins/woocommerce-blocks/.eslintrc.js
View File

@ -159,6 +159,7 @@ module.exports = {
'@woocommerce/settings',
'@woocommerce/shared-context',
'@woocommerce/shared-hocs',
'@woocommerce/tracks',
'@woocommerce/data',
'@wordpress/a11y',
'@wordpress/api-fetch',

2
plugins/woocommerce-blocks/package.json
View File

@ -45,7 +45,7 @@
"license": "GPL-3.0+",
"scripts": {
"analyze-bundles": "cross-env WP_BUNDLE_ANALYZER=1 pnpm run build",
"changelog": "composer install && composer exec -- changelogger",
"changelog": "XDEBUG_MODE=off composer install --quiet && composer exec -- changelogger",
"build": "pnpm --if-present --workspace-concurrency=Infinity --stream --filter=\"$npm_package_name...\" '/^build:project:.*$/'",
"build:project": "pnpm --if-present '/^build:project:.*$/'",
"build:project:bundle": "wireit",

4
plugins/woocommerce/changelog/dev-ci-tweaks-phpunit-runs Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: dev
CI: reduce running time for PHPUnit related jobs.

5
plugins/woocommerce/package.json
View File

@ -105,6 +105,7 @@
"tests": [
{
"name": "PHP",
"testType": "unit:php",
"command": "test:php:env",
"changes": [
"client/admin/config/*.json",
@ -128,6 +129,7 @@
},
{
"name": "PHP 8.0",
"testType": "unit:php",
"command": "test:php:env",
"changes": [
"client/admin/config/*.json",
@ -154,6 +156,7 @@
},
{
"name": "PHP WP: latest - 1",
"testType": "unit:php",
"command": "test:php:env",
"changes": [
"client/admin/config/*.json",
@ -180,6 +183,7 @@
},
{
"name": "PHP WP: latest - 2",
"testType": "unit:php",
"command": "test:php:env",
"changes": [
"client/admin/config/*.json",
@ -206,6 +210,7 @@
},
{
"name": "PHP WP: nightly",
"testType": "unit:php",
"command": "test:php:env",
"optional": true,
"changes": [

2
tools/monorepo-utils/dist/index.js vendored
View File

File diff suppressed because one or more lines are too long

8
tools/monorepo-utils/src/ci-jobs/lib/config.ts
View File

@ -24,7 +24,13 @@ export const enum JobType {
/**
* The type of the test job.
*/
export const testTypes = [ 'unit', 'e2e', 'api', 'performance' ] as const;
export const testTypes = [
'unit:php',
'unit',
'e2e',
'api',
'performance',
] as const;
/**
* The variables that can be used in tokens on command strings

5
tools/monorepo/check-changelogger-use.php
View File

@ -193,6 +193,11 @@ while ( ( $line = fgets( $pipes[1] ) ) ) {
}
continue;
}
// Ignore dot-files: those are development related, and it makes no sense to create a changelog entry for them.
if ( '.' === basename( $line )[0] ) {
debug( 'Ignoring changes dot-file %s.', $line );
continue;
}
debug( 'PR touches file %s, marking %s as touched.', $line, $project_match );
if ( ! isset( $touched_projects[ $project_match ] ) ) {