From 6d685e51850c7a7da0e4f76e376de16e70e3fc9a Mon Sep 17 00:00:00 2001 From: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> Date: Mon, 23 Oct 2023 13:08:03 -0700 Subject: [PATCH] Renamed `woocommerce/client/admin` Package NPM package names _must_ either be single-word or have a scope. The current structure is unsupported and has been changed. The new package name is `@woocommerce/admin-library`. --- .syncpackrc | 2 +- .../docs/examples/extensions/README.md | 2 +- .../woocommerce-admin/docs/features/navigation.md | 2 +- .../docs/features/payment-gateway-suggestions.md | 2 +- plugins/woocommerce-admin/package.json | 3 ++- plugins/woocommerce/README.md | 14 +++++++------- turbo.json | 4 ++-- 7 files changed, 15 insertions(+), 14 deletions(-) diff --git a/.syncpackrc b/.syncpackrc index 0dfffca54e2..fa0c145f9e1 100644 --- a/.syncpackrc +++ b/.syncpackrc @@ -130,7 +130,7 @@ "packages": [ "@woocommerce/block-templates", "@woocommerce/product-editor", - "woocommerce/client/admin", + "@woocommerce/admin-library", "@woocommerce/components" ], "isIgnored": true diff --git a/plugins/woocommerce-admin/docs/examples/extensions/README.md b/plugins/woocommerce-admin/docs/examples/extensions/README.md index 26689221298..b73604aaea5 100644 --- a/plugins/woocommerce-admin/docs/examples/extensions/README.md +++ b/plugins/woocommerce-admin/docs/examples/extensions/README.md @@ -14,7 +14,7 @@ Build the example extension by running the pnpm script and passing the example n ```bash -WC_EXT= pnpm --filter=woocommerce/client/admin example +WC_EXT= pnpm --filter=@woocommerce/admin-library example ``` You should see a new directory in `./woocommerce/plugins/{example} path.` Include the output plugin in your `.wp-env.json` or `.wp-env.override.json` and restart the WordPress instance. WooCommerce will now reflect the changes made by the example extension. diff --git a/plugins/woocommerce-admin/docs/features/navigation.md b/plugins/woocommerce-admin/docs/features/navigation.md index bf68adc4d5f..26592cd2442 100644 --- a/plugins/woocommerce-admin/docs/features/navigation.md +++ b/plugins/woocommerce-admin/docs/features/navigation.md @@ -10,7 +10,7 @@ This feature is hidden behind a feature flag and can be turned on or off by visi The fastest way to get started is by creating an example plugin from WooCommerce Admin. Enter the following command: -`WC_EXT=add-navigation-items pnpm example --filter=woocommerce/client/admin` +`WC_EXT=add-navigation-items pnpm example --filter=@woocommerce/admin-library` This will create a new plugin that covers various features of the navigation and helps to register some initial items and categories within the new navigation menu. After running the command above, you can make edits directly to the files at `docs/examples/extensions/add-navigation-items` and they will be built and copied to your `wp-content/add-navigation-items` folder on save. diff --git a/plugins/woocommerce-admin/docs/features/payment-gateway-suggestions.md b/plugins/woocommerce-admin/docs/features/payment-gateway-suggestions.md index b8ea6752f42..692c8681c0f 100644 --- a/plugins/woocommerce-admin/docs/features/payment-gateway-suggestions.md +++ b/plugins/woocommerce-admin/docs/features/payment-gateway-suggestions.md @@ -10,7 +10,7 @@ Gateway suggestions are retrieved from a REST API and can be added via a remote To quickly get started with an example plugin, run the following: -`WC_EXT=payment-gateway-suggestions pnpm example --filter=woocommerce/client/admin` +`WC_EXT=payment-gateway-suggestions pnpm example --filter=@woocommerce/admin-library` This will create a new plugin that when activated will add two new gateway suggestions. The first is a simple gateway demonstrating how configuration fields can be pulled from the gateway class to create a configuration form. The second gateway shows a more customized approach via SlotFill. diff --git a/plugins/woocommerce-admin/package.json b/plugins/woocommerce-admin/package.json index 298ddb885d3..1fa19de94a2 100644 --- a/plugins/woocommerce-admin/package.json +++ b/plugins/woocommerce-admin/package.json @@ -1,5 +1,6 @@ { - "name": "woocommerce/client/admin", + "name": "@woocommerce/admin-library", + "private": true, "version": "3.3.0", "license": "GPL-3.0-or-later", "author": "Automattic", diff --git a/plugins/woocommerce/README.md b/plugins/woocommerce/README.md index 0c5d2da5b85..8ec75f2a80f 100644 --- a/plugins/woocommerce/README.md +++ b/plugins/woocommerce/README.md @@ -47,11 +47,11 @@ This directory contains the React-based admin interface. ```bash # Build the React-based admin client. -pnpm run --filter=woocommerce/client/admin build +pnpm run --filter=@woocommerce/admin-library build # Lint the React-based admin client. -pnpm run --filter=woocommerce/client/admin lint +pnpm run --filter=@woocommerce/admin-library lint # Test the React-based admin client. -pnpm run --filter=woocommerce/client/admin test +pnpm run --filter=@woocommerce/admin-library test ``` #### Helper Scripts @@ -60,13 +60,13 @@ Here is a collection of scripts that can help when developing the React-based ad ```bash # Create a develoment build of the React-based admin client. -pnpm --filter=woocommerce/client/admin dev +pnpm --filter=@woocommerce/admin-library dev # Create and watch a development build of the React-based admin client. -pnpm --filter=woocommerce/client/admin start +pnpm --filter=@woocommerce/admin-library start # Watch the tests of the React-based admin client. -pnpm --filter=woocommerce/client/admin test:watch +pnpm --filter=@woocommerce/admin-library test:watch # Run a type check over the React-based admin client's TypeScript files. -pnpm --filter=woocommerce/client/admin ts:check +pnpm --filter=@woocommerce/admin-library ts:check ``` ## Documentation diff --git a/turbo.json b/turbo.json index 528d18835f0..32ef8bbf992 100644 --- a/turbo.json +++ b/turbo.json @@ -36,7 +36,7 @@ "dependsOn": [ "build:feature-config", "^turbo:build", - "woocommerce/client/admin#turbo:build", + "@woocommerce/admin-library#turbo:build", "woocommerce/client/legacy#turbo:build" ], "outputs": [], @@ -63,7 +63,7 @@ "outputMode": "new-only" }, - "woocommerce/client/admin#turbo:build": { + "@woocommerce/admin-library#turbo:build": { "dependsOn": [ "build:feature-config", "^turbo:build"