Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Numeric check needs to come after formatting the decimal

This commit is contained in:
Mike Jolley 2018-02-21 14:02:44 +00:00
parent ef393b8405
commit 700246345b
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
includes/class-wc-order-item-product.php
View File

@ -96,11 +96,13 @@ class WC_Order_Item_Product extends WC_Order_Item {
* @throws WC_Data_Exception * @throws WC_Data_Exception
*/ */
public function set_subtotal( $value ) { public function set_subtotal( $value ) {
$value = wc_format_decimal( $value );
if ( ! is_numeric( $value ) ) { if ( ! is_numeric( $value ) ) {
$value = 0; $value = 0;
} }
$this->set_prop( 'subtotal', wc_format_decimal( $value ) ); $this->set_prop( 'subtotal', $value );
} }
/** /**
@ -110,11 +112,13 @@ class WC_Order_Item_Product extends WC_Order_Item {
* @throws WC_Data_Exception * @throws WC_Data_Exception
*/ */
public function set_total( $value ) { public function set_total( $value ) {
$value = wc_format_decimal( $value );
if ( ! is_numeric( $value ) ) { if ( ! is_numeric( $value ) ) {
$value = 0; $value = 0;
} }
$this->set_prop( 'total', wc_format_decimal( $value ) ); $this->set_prop( 'total', $value );
// Subtotal cannot be less than total // Subtotal cannot be less than total
if ( '' === $this->get_subtotal() || $this->get_subtotal() < $this->get_total() ) { if ( '' === $this->get_subtotal() || $this->get_subtotal() < $this->get_total() ) {