From 7018ff47b65184614db3d62a05b34e020a30641f Mon Sep 17 00:00:00 2001
From: Karol Manijak <20098064+kmanijak@users.noreply.github.com>
Date: Fri, 21 Jul 2023 08:22:49 +0200
Subject: [PATCH] Add manual path to upgrade Products block
 (https://github.com/woocommerce/woocommerce-blocks/pull/10268)

* Add option to manually update Products block to Product Collection

* Disable manual upgrade of Products yet

* Manual update flag doesn't have to be dependant on auto update

* Removed commented out console info logs

* Disable option to upgrade Products block

* Change the way to bold text in Upgrade Notices so it's translatable

* Change the way UpgradeNotice is rendered conditionally
---
 .../inspector-controls/upgrade-notice.tsx     | 34 +++++++-------
 .../js/blocks/product-query/constants.ts      |  3 +-
 .../product-query/inspector-controls.tsx      | 15 ++++---
 .../inspector-controls/upgrade-notice.tsx     | 45 +++++++++++++++++++
 ...on-from-products-to-product-collection.tsx |  4 +-
 5 files changed, 75 insertions(+), 26 deletions(-)
 create mode 100644 plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls/upgrade-notice.tsx

diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-collection/inspector-controls/upgrade-notice.tsx b/plugins/woocommerce-blocks/assets/js/blocks/product-collection/inspector-controls/upgrade-notice.tsx
index 6885497b241..d9fe5b9607e 100644
--- a/plugins/woocommerce-blocks/assets/js/blocks/product-collection/inspector-controls/upgrade-notice.tsx
+++ b/plugins/woocommerce-blocks/assets/js/blocks/product-collection/inspector-controls/upgrade-notice.tsx
@@ -4,34 +4,34 @@
 import { __ } from '@wordpress/i18n';
 import { Notice, Button } from '@wordpress/components';
 import { BlockEditProps } from '@wordpress/blocks';
+import { createInterpolateElement } from '@wordpress/element';
 
 /**
  * Internal dependencies
  */
 import { ProductCollectionAttributes } from '../types';
 
-const FormattedNotice = ( { notice }: { notice: string } ) => {
-	const strongText = 'Product Collection';
-	const [ before, after ] = notice.split( strongText );
-
-	return (
-		<>
-			{ before }
-			<strong>{ strongText }</strong>
-			{ after }
-		</>
-	);
-};
-
 const UpgradeNotice = (
 	props: BlockEditProps< ProductCollectionAttributes > & {
 		revertMigration: () => void;
 	}
 ) => {
 	const { displayUpgradeNotice } = props.attributes;
-	const notice = __(
-		'Products (Beta) block was upgraded to Product Collection, an updated version with new features and simplified settings.',
-		'woo-gutenberg-products-block'
+	const notice = createInterpolateElement(
+		__(
+			'Products (Beta) block was upgraded to <strongText />, an updated version with new features and simplified settings.',
+			'woo-gutenberg-products-block'
+		),
+		{
+			strongText: (
+				<strong>
+					{ __(
+						`Product Collection`,
+						'woo-gutenberg-products-block'
+					) }
+				</strong>
+			),
+		}
 	);
 
 	const buttonLabel = __(
@@ -53,7 +53,7 @@ const UpgradeNotice = (
 
 	return displayUpgradeNotice ? (
 		<Notice onRemove={ handleRemove }>
-			<FormattedNotice notice={ notice } />
+			<>{ notice } </>
 			<br />
 			<br />
 			<Button variant="link" onClick={ handleClick }>
diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-query/constants.ts b/plugins/woocommerce-blocks/assets/js/blocks/product-query/constants.ts
index 8d821a76921..6235ac83594 100644
--- a/plugins/woocommerce-blocks/assets/js/blocks/product-query/constants.ts
+++ b/plugins/woocommerce-blocks/assets/js/blocks/product-query/constants.ts
@@ -13,7 +13,8 @@ import { VARIATION_NAME as PRODUCT_TITLE_ID } from './variations/elements/produc
 import { VARIATION_NAME as PRODUCT_TEMPLATE_ID } from './variations/elements/product-template';
 import { ImageSizing } from '../../atomic/blocks/product-elements/image/types';
 
-export const REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION = false;
+export const AUTO_REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION = false;
+export const MANUAL_REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION = false;
 
 export const EDIT_ATTRIBUTES_URL =
 	'/wp-admin/edit.php?post_type=product&page=product_attributes';
diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls.tsx b/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls.tsx
index 582a994d3ee..b48dc8bd229 100644
--- a/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls.tsx
+++ b/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls.tsx
@@ -38,11 +38,13 @@ import {
 	QUERY_DEFAULT_ATTRIBUTES,
 	QUERY_LOOP_ID,
 	STOCK_STATUS_OPTIONS,
-	REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION,
+	AUTO_REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION,
+	MANUAL_REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION,
 } from './constants';
 import { AttributesFilter } from './inspector-controls/attributes-filter';
 import { PopularPresets } from './inspector-controls/popular-presets';
 import { ProductSelector } from './inspector-controls/product-selector';
+import { UpgradeNotice } from './inspector-controls/upgrade-notice';
 import { replaceProductsWithProductCollection } from '../shared/scripts';
 
 import './editor.scss';
@@ -221,6 +223,11 @@ const ProductQueryControls = ( props: ProductQueryBlock ) => {
 	return (
 		<>
 			<InspectorControls>
+				{ MANUAL_REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION && (
+					<UpgradeNotice
+						upgradeBlock={ replaceProductsWithProductCollection }
+					/>
+				) }
 				{ allowedControls?.includes( 'presets' ) && (
 					<PopularPresets { ...props } />
 				) }
@@ -272,13 +279,9 @@ addFilter( 'editor.BlockEdit', QUERY_LOOP_ID, withProductQueryControls );
 
 if ( isWpVersion( '6.1', '>=' ) ) {
 	let unsubscribe: ( () => void ) | undefined;
-	if ( REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION && ! unsubscribe ) {
-		// console.info( 'Subscribed to allow Products block migration' );
+	if ( AUTO_REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION && ! unsubscribe ) {
 		unsubscribe = subscribe( () => {
 			replaceProductsWithProductCollection( () => {
-				// console.info(
-				// 	'Unsubscribed and disallow further Products block migration'
-				// );
 				if ( unsubscribe ) {
 					unsubscribe();
 				}
diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls/upgrade-notice.tsx b/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls/upgrade-notice.tsx
new file mode 100644
index 00000000000..cac8a043264
--- /dev/null
+++ b/plugins/woocommerce-blocks/assets/js/blocks/product-query/inspector-controls/upgrade-notice.tsx
@@ -0,0 +1,45 @@
+/**
+ * External dependencies
+ */
+import { __ } from '@wordpress/i18n';
+import { Notice, Button } from '@wordpress/components';
+import { createInterpolateElement } from '@wordpress/element';
+
+export const UpgradeNotice = ( props: { upgradeBlock: () => void } ) => {
+	const notice = createInterpolateElement(
+		__(
+			'Upgrade all Products (Beta) blocks on this page to <strongText /> for more features!',
+			'woo-gutenberg-products-block'
+		),
+		{
+			strongText: (
+				<strong>
+					{ __(
+						`Product Collection`,
+						'woo-gutenberg-products-block'
+					) }
+				</strong>
+			),
+		}
+	);
+
+	const buttonLabel = __(
+		'Upgrade to Product Collection',
+		'woo-gutenberg-products-block'
+	);
+
+	const handleClick = () => {
+		props.upgradeBlock();
+	};
+
+	return (
+		<Notice isDismissible={ false }>
+			<>{ notice }</>
+			<br />
+			<br />
+			<Button variant="link" onClick={ handleClick }>
+				{ buttonLabel }
+			</Button>
+		</Notice>
+	);
+};
diff --git a/plugins/woocommerce-blocks/assets/js/blocks/shared/scripts/migration-from-products-to-product-collection.tsx b/plugins/woocommerce-blocks/assets/js/blocks/shared/scripts/migration-from-products-to-product-collection.tsx
index 2b6f7a17162..2a803057442 100644
--- a/plugins/woocommerce-blocks/assets/js/blocks/shared/scripts/migration-from-products-to-product-collection.tsx
+++ b/plugins/woocommerce-blocks/assets/js/blocks/shared/scripts/migration-from-products-to-product-collection.tsx
@@ -195,7 +195,7 @@ const replaceProductsBlocks = ( productsBlockClientIds: string[] ) => {
 };
 
 export const replaceProductsWithProductCollection = (
-	unsubscribe: () => void
+	unsubscribe?: () => void
 ) => {
 	const queryBlocksCount =
 		select( 'core/block-editor' ).getGlobalBlockCount( 'core/query' );
@@ -213,7 +213,7 @@ export const replaceProductsWithProductCollection = (
 
 	const replaced = replaceProductsBlocks( productsBlockClientIds );
 
-	if ( replaced ) {
+	if ( unsubscribe && replaced ) {
 		// @todo: unsubscribe on user reverting migration
 		unsubscribe();
 	}