From 76d2b205e51311dac14fe83b96eaf7c96ce44596 Mon Sep 17 00:00:00 2001 From: Adrian Duffell <9312929+adrianduffell@users.noreply.github.com> Date: Fri, 7 Jun 2024 04:11:31 +0800 Subject: [PATCH] Disable Launch Your Store feature flag in 9.0 (#48231) * update: lys feature flag off (#46852) * Revert db update --------- Co-authored-by: RJ <27843274+rjchow@users.noreply.github.com> --- plugins/woocommerce/changelog/update-lys-feature-flag-off | 4 ++++ plugins/woocommerce/client/admin/config/core.json | 2 +- plugins/woocommerce/includes/class-wc-install.php | 3 --- plugins/woocommerce/includes/wc-update-functions.php | 7 ------- .../tests/e2e-pw/tests/merchant/launch-your-store.spec.js | 2 +- .../tests/e2e-pw/tests/shopper/launch-your-store.spec.js | 2 +- 6 files changed, 7 insertions(+), 13 deletions(-) create mode 100644 plugins/woocommerce/changelog/update-lys-feature-flag-off diff --git a/plugins/woocommerce/changelog/update-lys-feature-flag-off b/plugins/woocommerce/changelog/update-lys-feature-flag-off new file mode 100644 index 00000000000..051d48827c0 --- /dev/null +++ b/plugins/woocommerce/changelog/update-lys-feature-flag-off @@ -0,0 +1,4 @@ +Significance: minor +Type: update + +Toggle LYS feature flag off for 9.0 diff --git a/plugins/woocommerce/client/admin/config/core.json b/plugins/woocommerce/client/admin/config/core.json index 44cc7bfc98f..ef0ae6efa13 100644 --- a/plugins/woocommerce/client/admin/config/core.json +++ b/plugins/woocommerce/client/admin/config/core.json @@ -34,7 +34,7 @@ "wc-pay-promotion": true, "wc-pay-welcome-page": true, "async-product-editor-category-field": false, - "launch-your-store": true, + "launch-your-store": false, "product-editor-template-system": false } } diff --git a/plugins/woocommerce/includes/class-wc-install.php b/plugins/woocommerce/includes/class-wc-install.php index 0f703584eec..bcc10819ac6 100644 --- a/plugins/woocommerce/includes/class-wc-install.php +++ b/plugins/woocommerce/includes/class-wc-install.php @@ -255,9 +255,6 @@ class WC_Install { '8.9.1' => array( 'wc_update_891_create_plugin_autoinstall_history_option', ), - '9.0.0' => array( - 'wc_update_900_add_launch_your_store_tour_option', - ), ); /** diff --git a/plugins/woocommerce/includes/wc-update-functions.php b/plugins/woocommerce/includes/wc-update-functions.php index c900f1deb80..9c177fef81a 100644 --- a/plugins/woocommerce/includes/wc-update-functions.php +++ b/plugins/woocommerce/includes/wc-update-functions.php @@ -2724,10 +2724,3 @@ function wc_update_891_create_plugin_autoinstall_history_option() { } } } - -/** - * Add woocommerce_show_lys_tour. - */ -function wc_update_900_add_launch_your_store_tour_option() { - add_option( 'woocommerce_show_lys_tour', 'yes' ); -} diff --git a/plugins/woocommerce/tests/e2e-pw/tests/merchant/launch-your-store.spec.js b/plugins/woocommerce/tests/e2e-pw/tests/merchant/launch-your-store.spec.js index d6b6ad5e20e..1f77af2057d 100644 --- a/plugins/woocommerce/tests/e2e-pw/tests/merchant/launch-your-store.spec.js +++ b/plugins/woocommerce/tests/e2e-pw/tests/merchant/launch-your-store.spec.js @@ -2,7 +2,7 @@ const { test, expect, request } = require( '@playwright/test' ); const { setOption } = require( '../../utils/options' ); const wcApi = require( '@woocommerce/woocommerce-rest-api' ).default; -test.describe( 'Launch Your Store - logged in', () => { +test.describe.skip( 'Launch Your Store - logged in', () => { test.use( { storageState: process.env.ADMINSTATE } ); test.beforeEach( async ( { baseURL } ) => { diff --git a/plugins/woocommerce/tests/e2e-pw/tests/shopper/launch-your-store.spec.js b/plugins/woocommerce/tests/e2e-pw/tests/shopper/launch-your-store.spec.js index e8c932759f5..6eca0bced11 100644 --- a/plugins/woocommerce/tests/e2e-pw/tests/shopper/launch-your-store.spec.js +++ b/plugins/woocommerce/tests/e2e-pw/tests/shopper/launch-your-store.spec.js @@ -1,7 +1,7 @@ const { test, expect, request } = require( '@playwright/test' ); const { setOption } = require( '../../utils/options' ); -test.describe( 'Launch Your Store front end - logged out', () => { +test.describe.skip( 'Launch Your Store front end - logged out', () => { test.afterAll( async ( { baseURL } ) => { try { await setOption(