From 65aebd1e442d09e3a376a7a709680d3e69fe1a35 Mon Sep 17 00:00:00 2001 From: roykho Date: Tue, 3 May 2022 14:04:03 -0700 Subject: [PATCH 1/2] Use prevent double zip script --- .github/workflows/build-release-zip-file.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-release-zip-file.yml b/.github/workflows/build-release-zip-file.yml index 339b08c9cf9..7cea9a7854c 100644 --- a/.github/workflows/build-release-zip-file.yml +++ b/.github/workflows/build-release-zip-file.yml @@ -36,11 +36,14 @@ jobs: working-directory: plugins/woocommerce run: bash bin/build-zip.sh + - name: Unzip the file (prevents double zip problem) + run: unzip plugins/woocommerce/woocommerce.zip -d zipfile + - name: Upload the zip file as an artifact uses: actions/upload-artifact@v3 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: name: woocommerce - path: plugins/woocommerce/woocommerce.zip + path: zipfile retention-days: 7 From a632ca67fd631e00ee315516828e145a6eec4cc9 Mon Sep 17 00:00:00 2001 From: roykho Date: Tue, 3 May 2022 14:04:52 -0700 Subject: [PATCH 2/2] Lock build script php version environment for consistency --- .github/workflows/pr-build-and-e2e-tests.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/pr-build-and-e2e-tests.yml b/.github/workflows/pr-build-and-e2e-tests.yml index c25881341a6..9daa6932f15 100644 --- a/.github/workflows/pr-build-and-e2e-tests.yml +++ b/.github/workflows/pr-build-and-e2e-tests.yml @@ -32,6 +32,11 @@ jobs: if: steps.cache-deps.outputs.cache-hit != 'true' run: pnpm nx composer-install-no-dev woocommerce + - name: Setup PHP + uses: shivammathur/setup-php@v2 + with: + php-version: '7.4' + - name: Run build run: pnpm nx build woocommerce @@ -83,6 +88,11 @@ jobs: if: steps.cache-deps.outputs.cache-hit != 'true' run: pnpm nx composer-install woocommerce + - name: Setup PHP + uses: shivammathur/setup-php@v2 + with: + php-version: '7.4' + - name: Run build run: pnpm nx build woocommerce @@ -134,6 +144,11 @@ jobs: if: steps.cache-deps.outputs.cache-hit != 'true' run: pnpm nx composer-install woocommerce + - name: Setup PHP + uses: shivammathur/setup-php@v2 + with: + php-version: '7.4' + - name: Run build run: pnpm nx build woocommerce