Email notes now are turned off by default (https://github.com/woocommerce/woocommerce-admin/pull/6324)

* Email notes now are turned off by default

This commit turns off the email notes by default

* Added readme.txt

* Added testing instructions

Co-authored-by: Fernando Marichal <contacto@fernandomarichal.com>

plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md

@@ -3,6 +3,46 @@ Testing instructions
 
 ## Unreleased
 
+### Email notes now are turned off by default #6324
+
+-   Create a zip for testing with `npm run zip:test`.
+-   Create a `jurassic.ninja` instance.
+-   Upload the plugin and activate it.
+-   Update the installation date (we need a 10-day old store). You can do it with an SQL statement like this:
+
+```
+UPDATE `wp_options` SET `option_value`=UNIX_TIMESTAMP(DATE_SUB(NOW(), INTERVAL 10 day)) WHERE `option_name` = 'woocommerce_admin_install_timestamp';
+```
+
+-   Confirm that `woocommerce_merchant_email_notifications` was not set before by `core` with a SQL statement like:
+
+```
+DELETE FROM `wp_options` WHERE `wp_options`.`option_name` = 'woocommerce_merchant_email_notifications';
+```
+
+or with wp-cli:
+
+```
+wp option delete 'woocommerce_merchant_email_notifications';
+```
+
+-   Run the cron (this tool can help [WP Crontrol](https://wordpress.org/plugins/wp-crontrol/)).
+-   You should have not received an email note.
+-   Verify the note `wc-admin-add-first-product-note` was added in the DB and its `status` is `unactioned`. You can use a statement like this:
+
+```
+SELECT `status` FROM `wp_wc_admin_notes` WHERE `name` = 'wc-admin-add-first-product-note';
+```
+
+or with wp-cli:
+
+```
+wp db query 'SELECT status FROM wp_wc_admin_notes WHERE name = "wc-admin-add-first-product-note"' --skip-column-names
+```
+
+-   Run the cron again.
+-   The note's status should continue being `unactioned`.
+
 ### Remove CES actions for adding and editing a product and editing an order #6355
 
 1. Add a product. The customer effort score survey should not appear.

plugins/woocommerce-admin/readme.txt

@@ -82,6 +82,7 @@ Release and roadmap notes are available on the [WooCommerce Developers Blog](htt
 - Dev: Add unit tests to Navigation's Container component. #6344
 - Fix: Enqueue scripts called incorrectly in php unit tests #6358
 - Fix: Removed @woocommerce/components/card from OBW #6374
+- Fix: Email notes now are turned off by default #6324
 
 == 2.0.0 02/05/2021 ==
 

plugins/woocommerce-admin/src/Events.php

@@ -175,7 +175,7 @@ class Events {
 	 */
 	protected function is_merchant_email_notifications_enabled() {
 		// Check if the feature flag is disabled.
-		if ( 'yes' !== get_option( 'woocommerce_merchant_email_notifications', 'yes' ) ) {
+		if ( 'yes' !== get_option( 'woocommerce_merchant_email_notifications', 'no' ) ) {
 			return false;
 		}