Merge pull request #23457 from woocommerce/fix/23407-2

Fixed use of get_term_meta in REST API endpoints
This commit is contained in:
Mike Jolley 2019-04-24 14:34:28 +01:00 committed by GitHub
commit 7e091b2a0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 14 additions and 14 deletions

View File

@ -34,10 +34,10 @@ class WC_REST_Product_Categories_Controller extends WC_REST_Product_Categories_V
*/ */
public function prepare_item_for_response( $item, $request ) { public function prepare_item_for_response( $item, $request ) {
// Get category display type. // Get category display type.
$display_type = get_term_meta( $item->term_id, 'display_type' ); $display_type = get_term_meta( $item->term_id, 'display_type', true );
// Get category order. // Get category order.
$menu_order = get_term_meta( $item->term_id, 'order' ); $menu_order = get_term_meta( $item->term_id, 'order', true );
$data = array( $data = array(
'id' => (int) $item->term_id, 'id' => (int) $item->term_id,
@ -52,7 +52,7 @@ class WC_REST_Product_Categories_Controller extends WC_REST_Product_Categories_V
); );
// Get category image. // Get category image.
$image_id = get_term_meta( $item->term_id, 'thumbnail_id' ); $image_id = get_term_meta( $item->term_id, 'thumbnail_id', true );
if ( $image_id ) { if ( $image_id ) {
$attachment = get_post( $image_id ); $attachment = get_post( $image_id );

View File

@ -607,11 +607,11 @@ class WC_API_Products extends WC_API_Resource {
$term_id = intval( $term->term_id ); $term_id = intval( $term->term_id );
// Get category display type // Get category display type
$display_type = get_term_meta( $term_id, 'display_type' ); $display_type = get_term_meta( $term_id, 'display_type', true );
// Get category image // Get category image
$image = ''; $image = '';
if ( $image_id = get_term_meta( $term_id, 'thumbnail_id' ) ) { if ( $image_id = get_term_meta( $term_id, 'thumbnail_id', true ) ) {
$image = wp_get_attachment_url( $image_id ); $image = wp_get_attachment_url( $image_id );
} }

View File

@ -666,11 +666,11 @@ class WC_API_Products extends WC_API_Resource {
$term_id = intval( $term->term_id ); $term_id = intval( $term->term_id );
// Get category display type // Get category display type
$display_type = get_term_meta( $term_id, 'display_type' ); $display_type = get_term_meta( $term_id, 'display_type', true );
// Get category image // Get category image
$image = ''; $image = '';
if ( $image_id = get_term_meta( $term_id, 'thumbnail_id' ) ) { if ( $image_id = get_term_meta( $term_id, 'thumbnail_id', true ) ) {
$image = wp_get_attachment_url( $image_id ); $image = wp_get_attachment_url( $image_id );
} }

View File

@ -134,7 +134,7 @@ class WC_REST_Product_Attribute_Terms_V1_Controller extends WC_REST_Terms_Contro
*/ */
public function prepare_item_for_response( $item, $request ) { public function prepare_item_for_response( $item, $request ) {
// Get term order. // Get term order.
$menu_order = get_term_meta( $item->term_id, 'order_' . $this->taxonomy ); $menu_order = get_term_meta( $item->term_id, 'order_' . $this->taxonomy, true );
$data = array( $data = array(
'id' => (int) $item->term_id, 'id' => (int) $item->term_id,

View File

@ -52,10 +52,10 @@ class WC_REST_Product_Categories_V1_Controller extends WC_REST_Terms_Controller
*/ */
public function prepare_item_for_response( $item, $request ) { public function prepare_item_for_response( $item, $request ) {
// Get category display type. // Get category display type.
$display_type = get_term_meta( $item->term_id, 'display_type' ); $display_type = get_term_meta( $item->term_id, 'display_type', true );
// Get category order. // Get category order.
$menu_order = get_term_meta( $item->term_id, 'order' ); $menu_order = get_term_meta( $item->term_id, 'order', true );
$data = array( $data = array(
'id' => (int) $item->term_id, 'id' => (int) $item->term_id,
@ -70,7 +70,7 @@ class WC_REST_Product_Categories_V1_Controller extends WC_REST_Terms_Controller
); );
// Get category image. // Get category image.
$image_id = get_term_meta( $item->term_id, 'thumbnail_id' ); $image_id = get_term_meta( $item->term_id, 'thumbnail_id', true );
if ( $image_id ) { if ( $image_id ) {
$attachment = get_post( $image_id ); $attachment = get_post( $image_id );

View File

@ -34,10 +34,10 @@ class WC_REST_Product_Categories_V2_Controller extends WC_REST_Product_Categorie
*/ */
public function prepare_item_for_response( $item, $request ) { public function prepare_item_for_response( $item, $request ) {
// Get category display type. // Get category display type.
$display_type = get_term_meta( $item->term_id, 'display_type' ); $display_type = get_term_meta( $item->term_id, 'display_type', true );
// Get category order. // Get category order.
$menu_order = get_term_meta( $item->term_id, 'order' ); $menu_order = get_term_meta( $item->term_id, 'order', true );
$data = array( $data = array(
'id' => (int) $item->term_id, 'id' => (int) $item->term_id,
@ -52,7 +52,7 @@ class WC_REST_Product_Categories_V2_Controller extends WC_REST_Product_Categorie
); );
// Get category image. // Get category image.
$image_id = get_term_meta( $item->term_id, 'thumbnail_id' ); $image_id = get_term_meta( $item->term_id, 'thumbnail_id', true );
if ( $image_id ) { if ( $image_id ) {
$attachment = get_post( $image_id ); $attachment = get_post( $image_id );