Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix PHP Warning on 'Add new product' page (https://github.com/woocommerce/woocommerce-admin/pull/7989) 

* Fix method call

* Add changelog

* Add testing instructions

Co-authored-by: Fernando Marichal <contacto@fernandomarichal.com>
This commit is contained in:
Fernando 2021-12-02 09:55:21 -03:00 committed by GitHub
parent faf5d61f25
commit 7ea82c7778
3 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md
View File

@ -1,5 +1,15 @@
# Testing instructions
## Unreleased
### Fix PHP Warning on 'Add new product' page
0. On a Jurassic Ninja site.
1. Go to **WooCommerce** > **Home**.
2. Press **Add my products** in the task list.
3. Press **Add manually**.
4. No PHP warning should be visible.
## 3.0.0
### Onboarding Workflow - Add number of employees field

4
plugins/woocommerce-admin/changelogs/fix-7956 Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: Fix
Fix PHP Warning on 'Add new product' page #7989

2
plugins/woocommerce-admin/src/Features/OnboardingTasks/Task.php
View File

@ -318,7 +318,7 @@ abstract class Task {
* Set this as the active task across page loads.
*/
public function set_active() {
if ( $this->is_complete ) {
if ( $this->is_complete() ) {
return;
}