Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Moved resource check for `is_open()` method

This commit is contained in:
Claudio Sanches 2017-04-20 12:53:44 -03:00
parent aa21db2e64
commit 7f6b0c6d0f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
includes/log-handlers/class-wc-log-handler-file.php
View File

@ -163,7 +163,7 @@ class WC_Log_Handler_File extends WC_Log_Handler {
* @return bool True if $handle is open. * @return bool True if $handle is open.
*/ */
protected function is_open( $handle ) { protected function is_open( $handle ) {
return array_key_exists( $handle, $this->handles ); return is_resource( $this->handles[ $handle ] ) && array_key_exists( $handle, $this->handles );
} }
/** /**
@ -175,7 +175,7 @@ class WC_Log_Handler_File extends WC_Log_Handler {
protected function close( $handle ) { protected function close( $handle ) {
$result = false; $result = false;
if ( $this->is_open( $handle ) && is_resource( $this->handles[ $handle ] ) ) { if ( $this->is_open( $handle ) ) {
$result = fclose( $this->handles[ $handle ] ); $result = fclose( $this->handles[ $handle ] );
unset( $this->handles[ $handle ] ); unset( $this->handles[ $handle ] );
} }
@ -266,7 +266,7 @@ class WC_Log_Handler_File extends WC_Log_Handler {
protected function should_rotate( $handle ) { protected function should_rotate( $handle ) {
$file = self::get_log_file_path( $handle ); $file = self::get_log_file_path( $handle );
if ( $file ) { if ( $file ) {
if ( $this->is_open( $handle ) && is_resource( $this->handles[ $handle ] ) ) { if ( $this->is_open( $handle ) ) {
$file_stat = fstat( $this->handles[ $handle ] ); $file_stat = fstat( $this->handles[ $handle ] );
return $file_stat['size'] > $this->log_size_limit; return $file_stat['size'] > $this->log_size_limit;
} elseif ( file_exists( $file ) ) { } elseif ( file_exists( $file ) ) {